fix: fall back to getent for users that are not findable in /etc/passwd (backport #183 to 1.5)#213
Merged
tonyandrewmeyer merged 1 commit intoJun 17, 2026
Conversation
…wd (canonical#183) The go `User.Lookup` method on Unix-like systems without ego [just looks in the /etc/password file](https://github.com/golang/go/blob/master/src/os/user/lookup_unix.go#L218) (whereas cgo [does a getpwnam check via libc](https://github.com/golang/go/blob/master/src/os/user/cgo_lookup_unix.go#L22)). On some systems, like the Canonical laptops, the user that is trying to run Concierge may not be in `/etc/passwd` and be loaded from a directory service instead. This PR adds a fallback system where we will run the [getent](https://manpages.ubuntu.com/manpages/noble/en/man1/getent.1.html) binary. That comes from the `libc-bin` package in Ubuntu, so is very likely to be available (and the worst case is that it's not and we'll fail just as we did before). Fixes canonical#182 --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit 5b915d8)
james-garner-canonical
approved these changes
Jun 17, 2026
james-garner-canonical
left a comment
james-garner-canonical
left a comment
Contributor
There was a problem hiding this comment.
Another clean backport, and familiar context (supporting NSS-managed systems).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #183 to the 1.5-maintenance line.
Clean cherry-pick of 5b915d8; tests pass (including the new internal/system/util_test.go).