docs: document how to use the completion module#326
Merged
Conversation
bepri
force-pushed
the
work/document-completion/CRAFT-4034
branch
from
3ffe9b8 to
5992031
Compare
Member
Author
tigarmo
reviewed
Feb 10, 2025
tigarmo
approved these changes
Feb 11, 2025
medubelko
requested changes
Feb 11, 2025
Contributor
medubelko
left a comment
medubelko
left a comment
There was a problem hiding this comment.
A few suggestions, but most of these are technical questions.
lengau
reviewed
Feb 12, 2025
lengau
reviewed
Feb 12, 2025
medubelko
approved these changes
Feb 13, 2025
Contributor
medubelko
left a comment
medubelko
left a comment
There was a problem hiding this comment.
Looks good! The first three suggestions here are moderately important from a docs perspective.
bepri
force-pushed
the
work/document-completion/CRAFT-4034
branch
from
cb7b462 to
75f2f99
Compare
bepri
pushed a commit
that referenced
this pull request
May 7, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox?To help a bit with the review of accuracy, here's me using the module in Snapcraft.
get_app_info(): https://github.com/canonical/snapcraft/blob/7254a4bd5a9f4b5a22c979c9b86fa364f2232fcf/snapcraft/application.py#L475