Skip to content

Add verfication of checksum for yq binary#143

Closed
yhaliaw wants to merge 2 commits intomainfrom
bug/verify-downloaded-binary
Closed

Add verfication of checksum for yq binary#143
yhaliaw wants to merge 2 commits intomainfrom
bug/verify-downloaded-binary

Conversation

@yhaliaw
Copy link
Copy Markdown
Collaborator

@yhaliaw yhaliaw commented Oct 27, 2023

Overview

Add checkout verification of yq binary.

Rationale

Verify the yq binary in the runners are correct.

Our e2e test would only test if the yq binary downloaded in the e2e test is correct, but not what the runner downloaded during deployment.

Checklist

The integration test/e2e test would test if the checksum downloaded matches.
The e2e test would test if the yq binary is working.

@github-actions
Copy link
Copy Markdown
Contributor

Test coverage for 3284750

Name                    Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------
src/charm.py              413     95     99     20    75%   80-82, 108-110, 142-144, 204-212, 224-228, 328-333, 354, 371-377, 386-409, 427-429, 437-440, 447, 450-451, 467, 472-477, 522->525, 538-539, 541-542, 576-583, 607-608, 620-622, 637-638, 663-664, 666-667, 669-670, 744->746, 806-807, 823, 841-843, 847
src/charm_state.py         12      0      2      0   100%
src/errors.py              32      0      0      0   100%
src/event_timer.py         42      8      4      0    74%   94-97, 117-120
src/firewall.py            43     25     10      0    38%   38-42, 64-67, 75-149
src/github_type.py         36      0      0      0   100%
src/lxd_type.py            37      0      2      0   100%
src/metrics.py             55      2     10      1    95%   60->63, 112-113
src/runner.py             321     67     98     23    75%   48->52, 108->110, 214-221, 227-233, 260-261, 305-314, 338-343, 348, 368, 372-382, 431->434, 437-439, 446, 460, 470, 474, 476, 491, 538-543, 561, 654, 689, 715, 720-732, 746, 764, 788, 805-820, 828-848
src/runner_manager.py     245     26     92      9    88%   162, 219-221, 234-235, 247-249, 255-260, 264-265, 275-276, 295, 403, 424-428, 447, 465, 613, 633
src/runner_metrics.py      97      5     18      2    94%   122-123, 135, 185-186
src/runner_type.py         53      0     12      0   100%
src/shared_fs.py           80     10     12      0    89%   73-74, 160-161, 166-167, 173-174, 196-197
src/utilities.py           68      6     20      8    84%   74->76, 78->84, 89-91, 117, 131, 169, 222
-------------------------------------------------------------------
TOTAL                    1534    244    379     63    82%

Static code analysis report

Run started:2023-10-29 02:36:44.378860

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3454
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 9

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yhaliaw
Copy link
Copy Markdown
Collaborator Author

yhaliaw commented Nov 23, 2023

Moved to #149

@yhaliaw yhaliaw closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant