Conversation
Contributor
There was a problem hiding this comment.
license-eye has totally checked 104 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 48 | 1 | 55 | 0 |
Click to see the invalid file list
- scripts/build-image.sh
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
6 tasks
cbartz
reviewed
Dec 7, 2023
Collaborator
cbartz
left a comment
There was a problem hiding this comment.
Could you please update the PR description, as it seems in this PR no workflow is used to build the images on a daily basis and push them to github, but the images are built in the charm itself periodically.
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
jdkandersson
previously approved these changes
Dec 7, 2023
jdkandersson
previously approved these changes
Dec 8, 2023
jdkandersson
previously approved these changes
Dec 8, 2023
jdkandersson
previously approved these changes
Dec 8, 2023
Contributor
|
Do we need any updates to the documentation here please? Perhaps to the architecture to explain that the image is built now and re-used? |
Collaborator
Author
Updated the docs |
cbartz
previously approved these changes
Dec 8, 2023
jdkandersson
previously approved these changes
Dec 8, 2023
jdkandersson
approved these changes
Dec 8, 2023
Contributor
|
Test coverage for ae68a59 Static code analysis report |
cbartz
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The runner image is built within the charm on a schedule.
Rationale
Building the runner images allow for pre-loading packages, and modifying configurations.
This PR will enable SCTP support which should be included in the e2e test.
Checklist
src-docsurgent,trivial,complex)WIP