Add unit and integration tests for http lib#12
Closed
Thanhphan1147 wants to merge 51 commits intomainfrom
Closed
Conversation
yanksyoon
reviewed
Sep 3, 2024
Member
yanksyoon
left a comment
yanksyoon
left a comment
There was a problem hiding this comment.
Reviewd up to state/tls.py!
| self-hosted-runner: true | ||
| self-hosted-runner-label: "edge" | ||
| charmcraft-channel: latest/edge | ||
| modules: '["test_action.py", "test_charm.py"]' No newline at end of file |
Member
There was a problem hiding this comment.
I think there's a missing newline here :)
|
|
||
| rules: | ||
| # Ignore whitelist - we are using it to ignore pydantic in pyptoject.toml | ||
| - name: whitelist No newline at end of file |
Member
There was a problem hiding this comment.
I think there's a missing newline here :)
| * metadata.yaml > published on Charmhub | ||
| * documentation > published on (or linked to from) Charmhub | ||
| * detailed contribution guide > documentation or CONTRIBUTING.md | ||
| A Juju charm that deploys and manages haproxy on machine. HAProxy is a TCP/HTTP reverse proxy which is particularly suited for high availability environments. It features connection persistence through HTTP cookies, load balancing, header addition, modification, deletion both ways. It has request blocking capabilities and provides interface to display server status. |
Member
There was a problem hiding this comment.
s/manages haproxy on machine/manges haproxy on a VM/
| jinja2==3.1.4 | ||
| jsonschema==4.23.0 | ||
| ops==2.15.0 | ||
| pydantic==2.8.2 No newline at end of file |
Member
There was a problem hiding this comment.
I think there's a missing new line here :D
Collaborator
Author
|
closing as dups with #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
src-docsurgent,trivial,complex)