Skip to content

ISD-2184 Implement reverseproxy relation#14

Merged
Thanhphan1147 merged 143 commits intomainfrom
parse_services_configuration
Oct 16, 2024
Merged

ISD-2184 Implement reverseproxy relation#14
Thanhphan1147 merged 143 commits intomainfrom
parse_services_configuration

Conversation

@Thanhphan1147
Copy link
Collaborator

@Thanhphan1147 Thanhphan1147 commented Sep 2, 2024

Implement support for the reverseproxy:http relation. As we prioritize having feature parity with the legacy haproxy charm as well as for the new charm to be a drop-in replacement, part of the code of the legacy charm is added and isolated in the legacy.py module (all lint checks disabled).

Supported workflow:

juju deploy pollen
juju deploy ./haproxy_amd64.charm
juju relate pollen haproxy
curl <haproxy_unit_ip>

Checklist

@Thanhphan1147 Thanhphan1147 changed the title Implement reverseproxy relation ISD-2184 Implement reverseproxy relation Sep 3, 2024
@Thanhphan1147 Thanhphan1147 force-pushed the parse_services_configuration branch from ba7969d to 84f28b1 Compare October 7, 2024 00:47
@Thanhphan1147 Thanhphan1147 requested a review from yhaliaw October 15, 2024 08:59
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments. I am missing unit tests for the changes. @Thanhphan1147

@github-actions
Copy link
Contributor

Test coverage for 1f0ad38

Name                      Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------
src/charm.py                 92     43     12      0    47%   80-81, 86-87, 92, 101-103, 112-115, 126-133, 140-141, 149-162, 166, 170, 174-176, 180-195
src/haproxy.py               47     10      2      1    78%   64, 73-74, 91-100, 110-112
src/http_interface.py        65     23      4      0    61%   73, 82, 91, 96, 105-107, 125, 137, 149, 161, 169-174, 189-199
src/state/config.py          40     22      6      0    39%   50-70, 85-93, 105-106
src/state/tls.py             38     12      6      1    61%   55-68, 91-96
src/state/validation.py      31     17      6      0    38%   59-75
src/tls_relation.py         117      2     18      1    96%   254-255, 263->266
---------------------------------------------------------------------
TOTAL                       430    129     54      3    66%

Static code analysis report

Run started:2024-10-16 12:14:44.254414

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1869
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 3

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147 Thanhphan1147 requested a review from cbartz October 16, 2024 12:36
@Thanhphan1147
Copy link
Collaborator Author

@cbartz can I ask you to take a look at the PR again and leave your reviews? I'll add the unit tests in a follow-up PR.

Thanks!

@Thanhphan1147 Thanhphan1147 merged commit 98d3b05 into main Oct 16, 2024
@Thanhphan1147 Thanhphan1147 deleted the parse_services_configuration branch October 16, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants