ISD-2184 Implement reverseproxy relation#14
Merged
Thanhphan1147 merged 143 commits intomainfrom Oct 16, 2024
Merged
Conversation
This was referenced Sep 3, 2024
ba7969d to
84f28b1
Compare
yhaliaw
reviewed
Oct 15, 2024
cbartz
reviewed
Oct 16, 2024
Contributor
cbartz
left a comment
There was a problem hiding this comment.
LGTM, minor comments. I am missing unit tests for the changes. @Thanhphan1147
Contributor
|
Test coverage for 1f0ad38 Static code analysis report |
Collaborator
Author
|
@cbartz can I ask you to take a look at the PR again and leave your reviews? I'll add the unit tests in a follow-up PR. Thanks! |
cbartz
approved these changes
Oct 16, 2024
gregory-schiano
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for the
reverseproxy:httprelation. As we prioritize having feature parity with the legacy haproxy charm as well as for the new charm to be a drop-in replacement, part of the code of the legacy charm is added and isolated in thelegacy.pymodule (all lint checks disabled).Supported workflow:
Checklist
src-docsurgent,trivial,complex)