Skip to content

add ADR for the port-mapping feature#575

Merged
Thanhphan1147 merged 1 commit into
mainfrom
adr-haproxy-route-tcp-port-range
Jul 6, 2026
Merged

add ADR for the port-mapping feature#575
Thanhphan1147 merged 1 commit into
mainfrom
adr-haproxy-route-tcp-port-range

Conversation

@Thanhphan1147

@Thanhphan1147 Thanhphan1147 commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does

Introduce the first ADR that covers design decisions tken for the port-mapping feature of haproxy-route-tcp

Why we need it

Checklist

  • I followed the contributing guide
  • I added or updated the documentation (if applicable)
  • I updated docs/changelog.md with user-relevant changes
  • I added a change artifact for user-relevant changes in docs/release-notes/artifacts. If no change artifact is necessary, I tagged the PR with the label no-release-note.
  • I used AI to assist with preparing this PR
  • I added or updated tests as needed (unit and integration)
  • If integration test modules are used: I updated the workflow configuration
    (e.g., in .github/workflows/integration_tests.yaml, ensure the modules list is correct)
  • If this PR involves a Grafana dashboard: I added a screenshot of the dashboard
  • If this PR involves Terraform: terraform fmt passes and tflint reports no errors

@Thanhphan1147
Thanhphan1147 requested a review from a team as a code owner June 25, 2026 18:36
@Thanhphan1147 Thanhphan1147 added documentation Improvements or additions to documentation no-release-note This PR does not require a change artifact labels Jun 25, 2026
@Thanhphan1147
Thanhphan1147 force-pushed the adr-haproxy-route-tcp-port-range branch from 3af198e to 62b5eff Compare July 6, 2026 08:27
@Thanhphan1147
Thanhphan1147 enabled auto-merge (squash) July 6, 2026 08:27
f-atwi
f-atwi approved these changes Jul 6, 2026
View reviewed changes

@f-atwi f-atwi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! clear and concise

@Thanhphan1147
Thanhphan1147 merged commit 5b2d2b6 into main Jul 6, 2026
98 checks passed
@Thanhphan1147
Thanhphan1147 deleted the adr-haproxy-route-tcp-port-range branch July 6, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f-atwi f-atwi f-atwi approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation Libraries: Out of sync no-release-note This PR does not require a change artifact

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Thanhphan1147 @f-atwi