Pin down LXD and use dqlite LTS for microcluster#464
Merged
roosterfish merged 2 commits intocanonical:mainfrom Nov 7, 2024
Merged
Pin down LXD and use dqlite LTS for microcluster#464roosterfish merged 2 commits intocanonical:mainfrom
roosterfish merged 2 commits intocanonical:mainfrom
Conversation
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
commented
Nov 6, 2024
Contributor
Author
|
@masnax looks one more dependency went into stable right before our release, see https://github.com/charmbracelet/lipgloss/releases/tag/v1.0.0 |
tomponline
previously approved these changes
Nov 6, 2024
roosterfish
force-pushed
the
lts_additions
branch
2 times, most recently
from
f435302 to
4380e8e
Compare
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
lts_additions
branch
from
4380e8e to
1863768
Compare
tomponline
approved these changes
Nov 7, 2024
tomponline
reviewed
Nov 7, 2024
| github.com/charmbracelet/lipgloss v0.13.0 | ||
| github.com/creack/pty v1.1.23 | ||
| github.com/canonical/microcluster/v2 v2.0.5 | ||
| github.com/canonical/microovn/microovn v0.0.0-20241101125123-0d5d663f6575 |
Member
There was a problem hiding this comment.
we should update the makefile update-gomod to target microovn and microceph LTS branches
sabaini
pushed a commit
to canonical/microceph
that referenced
this pull request
Nov 7, 2024
### Pin LXD When defining the microcluster API handlers you have to import from `"github.com/canonical/lxd/lxd/response"` for the handlers return value. As this dependency can diverge from the same import that microcluster users internally, you might end up with build issues if you don't use the same version as microcluster. We have already [filed an improvement](canonical/microcluster#282) in microcluster to address this in future releases. But for now pinning down the version is a good measure to prevent build errors in the future during maintenance of the LTS. The same measure is [applied in microcluster](https://github.com/canonical/microcluster/blob/v2/Makefile#L51) to ensure every downstream can stay on track with the used version of LXD. See [this PR](canonical/microcloud#464) for the same change in MicroCloud and [this PR](canonical/microovn#202) for MicroOVN. ### Dqlite LTS In addition microcluster is updated to `v2.0.5` which uses dqlite `v2` LTS. --------- Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Contributor
This is from |
Contributor
|
Has this been tested yet to ensure dqlite leader detection is working okay? We may need to tweak the default heartbeat interval and max concurrent leader connections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure we always only pull the LXD dependency from
@stable-5.21and use microclusterv2.0.5which contains the dqlite LTS.