Skip to content

CLI: Exit add command in case no new system got selected - #838

Merged
roosterfish merged 1 commit into
canonical:mainfrom
roosterfish:fix_add_no_new_systems
Jul 10, 2025
Merged

CLI: Exit add command in case no new system got selected#838
roosterfish merged 1 commit into
canonical:mainfrom
roosterfish:fix_add_no_new_systems

Conversation

@roosterfish

@roosterfish roosterfish commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

In case no new system got selected with the init subcommand, the questionnaire falls back to creating a single node MicroCloud. In case of the add subcommand, there has to be at least one new system to continue.

The check itself cannot be done inside the initiating session because the same session func is used for both the init and add subcommands.

The check itself cannot be done inside the initiating session because the same session func is used
for both the init and add subcommands.
In case no new system got selected with the init subcommand, the questionnaire falls back to creating a single node MicroCloud.
In case of the add subcommand there has to be at least one new system to continue.

Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
@roosterfish
roosterfish force-pushed the fix_add_no_new_systems branch from 7171249 to 4e6330e Compare June 30, 2025 07:17
@roosterfish
roosterfish requested a review from markylaing June 30, 2025 07:17
@roosterfish

roosterfish commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

The e2e test failure is unrelated to this change.

@roosterfish roosterfish changed the title Cmd: Exit add command in case no new system got selected CLI: Exit add command in case no new system got selected Jul 4, 2025

@markylaing markylaing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks.

@roosterfish
roosterfish merged commit d238301 into canonical:main Jul 10, 2025
45 of 46 checks passed
@roosterfish
roosterfish deleted the fix_add_no_new_systems branch July 10, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants