doc: fix internal link targets - #896
Merged
Merged
Conversation
Signed-off-by: Minae Lee <minae.lee@canonical.com>
Merged
roosterfish
approved these changes
Jul 25, 2025
roosterfish
left a comment
roosterfish
left a comment
Contributor
There was a problem hiding this comment.
Good catch! Just to clarify, in case there are two refs with the same name on both LXD and MC, does the one from MC take precedence?
Contributor
|
Can we prefix the ones coming from LXD? |
Author
Yes, if no prefix is set (like |
Author
They are already prefixed, but the issue is that those links don't yet exist in LXD stable-5.21 because those docs haven't been backported. Working on that backport now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes link targets that are intended to point to MicroCloud internal docs but are pointing at LXD's docs through intersphinx. Due to the link targets existing in LXD latest branch, the links did not raise an error, but the issue showed up in a backport PR where the LXD branch used in the backport (stable-5.21) does not yet have those link targets.