feat: add weekly snap promotions - #492
Merged
Merged
Conversation
sed-i
reviewed
Aug 25, 2026
| - name: Promote snap | ||
| env: | ||
| SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_STORE_CREDENTIALS }} | ||
| run: just promote-snap-train ${{ matrix.snap }} |
Contributor
There was a problem hiding this comment.
This seems like a blind promotion, not a "low pass filter" of one week delay. Was this intentional?
Contributor
Author
There was a problem hiding this comment.
Seems like the plan is to wait a week after upstream releases to avoid promoting "quickly-fixed bugs" to /stable. Ideally the workflow would track all new releases to /edge, and whenever one has been released for over a week, we would promote that to /stable.
There are some corner cases here:
- If we get a new version every week (though unlikely) we wouldn't be promoting to
/stableanymore (maybe it'd be a sign the project itself is not stable?)
Contributor
Author
|
Merging this so we at least have a baseline, as currently nothing is promoted to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
/edgeto/stableon all their available tracks, to be run automatically on a weekly basis;promote-charm-trainworkflow and justfile recipe to read frommanifest.yamlinstead of using a hardcoded list of charms.