Skip to content

docs: replace requests by urllib in K8s tutorial integration tests - #2687

Merged
dwilding merged 3 commits into
canonical:mainfrom
dwilding:adjust-k8s-tutorial
Aug 24, 2026
Merged

docs: replace requests by urllib in K8s tutorial integration tests#2687
dwilding merged 3 commits into
canonical:mainfrom
dwilding:adjust-k8s-tutorial

Conversation

@dwilding

@dwilding dwilding commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

As discussed internally yesterday, the integration tests in Observe your charm with COS Lite use requests.get to talk to Loki. That's an unnecessary dependency. In the charm code itself, we use urllib.request.urlopen to talk to the workload. This PR updates the integration tests to use a similar approach.

Preview doc

@dwilding
dwilding requested review from hpidcock and tromai August 11, 2026 23:49

@tromai tromai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Thank you for the PR.

@hpidcock hpidcock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwilding
dwilding merged commit 728eb3d into canonical:main Aug 24, 2026
60 checks passed
@dwilding
dwilding deleted the adjust-k8s-tutorial branch August 24, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants