Skip to content

Conversation

@dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Sep 11, 2025

Handle invalid stanza name in Pgbackrest output (happens when no region is set in GCP) to block as failure to initialise stanza and not as foreign backup

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@dragomirp dragomirp added the bug Something isn't working as expected label Sep 11, 2025
@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.57%. Comparing base (916c5bf) to head (03b3531).
⚠️ Report is 2 commits behind head on 16/edge.

❌ Your project status has failed because the head coverage (64.57%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge    #1154      +/-   ##
===========================================
+ Coverage    64.55%   64.57%   +0.02%     
===========================================
  Files           17       17              
  Lines         4325     4328       +3     
  Branches       668      669       +1     
===========================================
+ Hits          2792     2795       +3     
  Misses        1351     1351              
  Partials       182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragomirp dragomirp force-pushed the handle-invalid-system-id branch from 7d5c4e6 to 61ecd03 Compare September 11, 2025 11:14
@dragomirp dragomirp changed the title [MISC] Handle invalid system [MISC] Handle invalid stanza name Sep 11, 2025
@dragomirp dragomirp marked this pull request as ready for review September 11, 2025 14:17
@dragomirp dragomirp requested review from a team, marceloneppel and taurus-forever and removed request for a team September 11, 2025 14:17
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! LGTM.

@dragomirp dragomirp merged commit d1e7c54 into 16/edge Sep 15, 2025
309 of 317 checks passed
@dragomirp dragomirp deleted the handle-invalid-system-id branch September 15, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants