Fix machine details for a machine with tags#236
Merged
sparkiegeek merged 4 commits intocanonical:masterfrom Feb 28, 2020
Merged
Fix machine details for a machine with tags#236sparkiegeek merged 4 commits intocanonical:masterfrom
sparkiegeek merged 4 commits intocanonical:masterfrom
Conversation
Viscera layer produces a Tags.Managed object for machines with tags, this can't be str()ified.
sparkiegeek
force-pushed
the
render-tags
branch
from
8083127 to
21dfd83
Compare
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=========================================
Coverage ? 67.98%
=========================================
Files ? 70
Lines ? 5726
Branches ? 988
=========================================
Hits ? 3893
Misses ? 1610
Partials ? 223
Continue to review full report at Codecov.
|
bjornt
reviewed
Feb 28, 2020
| output = yaml.safe_load( | ||
| cmd.execute(origin, options, target=tabular.RenderTarget.yaml) | ||
| ) | ||
| self.assertEqual(output.get("tags"), "tag1, tag2") |
Contributor
There was a problem hiding this comment.
Wouldn't it make sense for the yaml renderer to render the tags as a list of strings?
Contributor
Author
There was a problem hiding this comment.
Good point, fixed!
sparkiegeek
force-pushed
the
render-tags
branch
from
155a7d3 to
e250f29
Compare
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viscera layer produces a Tags.Managed object for machines with tags, this can't be simply str()ified.
Added a simple test for this behaviour, but there's a gap of testing for machine details in general.
Drive-by cleaned up a
yaml.loadAn example of how this looks for the plain renderer: