tests: change arg order for runuser in tests.session - #16865
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16865 +/- ##
==========================================
- Coverage 77.63% 77.62% -0.01%
==========================================
Files 1361 1358 -3
Lines 189322 189226 -96
Branches 2446 2446
==========================================
- Hits 146971 146892 -79
+ Misses 33478 33454 -24
- Partials 8873 8880 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tue Apr 7 07:26:24 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
zyga
reviewed
Apr 6, 2026
| --setenv TERM=xterm-256color \ | ||
| --property "Environment=SNAPD_DEBUG=$SNAPD_DEBUG SNAP_REEXEC=$SNAP_REEXEC SNAP_CONFINE_DEBUG=$SNAP_CONFINE_DEBUG" \ | ||
| $selinux_context_arg \ | ||
| "$(command -v runuser)" -l "$user" $runuser_env_arg - -c "exec $tmp_dir/exec" || true |
Contributor
There was a problem hiding this comment.
@maykathm isn't the removal of - the actual change here?
Contributor
Author
There was a problem hiding this comment.
No, it's flipping the order, as discussed in the bug report. I removed the - while I was at it.
Rnfudge02
pushed a commit
to Rnfudge02/snapd
that referenced
this pull request
Apr 10, 2026
maykathm
added a commit
to maykathm/snapd
that referenced
this pull request
Apr 29, 2026
Closed
maykathm
added a commit
to maykathm/snapd
that referenced
this pull request
Apr 29, 2026
ernestl
pushed a commit
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the most recent versions of runuser, a bug in argument parsing causes tests to fail on debian sid. As a workaround, we can change the argument order (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1132588#10)