TO-299: move match artefact to queries.py#661
Merged
almeidaraul merged 10 commits intomainfrom Mar 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Moves artefact-to-matching-rule selection logic out of the test execution controller and into data_access so reviewer assignment can reuse centralized query-building.
Changes:
- Added
match_artefact()SQLAlchemy query helper to select the most specificArtefactMatchingRule(s) for anArtefact. - Refactored reviewer assignment in
start_test.pyto callmatch_artefact()and fetch matching teams/users via rule IDs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
backend/test_observer/data_access/queries.py |
Introduces a reusable query helper to select the most specific matching-rule IDs for an artefact. |
backend/test_observer/controllers/test_executions/start_test.py |
Replaces in-controller matching-rule filtering/sorting with the centralized match_artefact() query. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
backend/test_observer/controllers/test_executions/start_test.py
Outdated
Show resolved
Hide resolved
wctaylor
requested changes
Mar 26, 2026
Collaborator
wctaylor
left a comment
wctaylor
left a comment
There was a problem hiding this comment.
Looks pretty solid! Just a few minor changes I'd like to see
backend/test_observer/controllers/test_executions/start_test.py
Outdated
Show resolved
Hide resolved
backend/test_observer/controllers/test_executions/start_test.py
Outdated
Show resolved
Hide resolved
wctaylor
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Matching AMRs to artefacts was not centralized/coupled to the AMR model. Now it is part of
data_access.Resolved issues
This is part of TO-299
Documentation
No changes
Web service API changes
No changes
Tests
No changes to test, they all pass