Open
Conversation
almeidaraul
requested review from
Copilot and
uyarahmet
and removed request for
uyarahmet
There was a problem hiding this comment.
Pull request overview
Adds Jira card creation support for TO-40 by extending the Jira client with an issue-creation API and introducing a helper to create review cards for artefacts/environments, with accompanying tests.
Changes:
- Added
JiraClient.create_issue()to create Jira issues via REST API v3. - Added
create_artefact_review_cards()to generate two Jira “review” tasks linked to an artefact’s Jira issue. - Added test coverage for Jira issue creation and review-card creation behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| backend/test_observer/external_apis/jira/jira_client.py | Implements Jira issue creation and error logging for failed creates |
| backend/test_observer/controllers/test_executions/start_test.py | Adds helper to create Jira review cards during start-test flow |
| backend/tests/external_apis/test_external_api_clients.py | Adds unit tests for successful and failing Jira issue creation |
| backend/tests/controllers/test_executions/test_start_test.py | Adds tests validating review-card creation and “skip” conditions |
backend/test_observer/controllers/test_executions/start_test.py
Outdated
Show resolved
Hide resolved
backend/test_observer/controllers/test_executions/start_test.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This card is part of TO-40 and adds functionality to create jira cards (from the
JiraClientimplementation) and to create jira cards for review of artefacts and environments (fromstart_test.py).The only missing part of TO-40 will be to trigger the card creation when assigning reviewers, which I'll wait for #661 to be merged before doing.
Resolved issues
Part of TO-40
Documentation
Web service API changes
Tests
For the Jira Client, there are tests for
As for the reviewer card creation function, there are tests for
jira_issueattribute