Skip to content

Issue #1 - #3

Merged
rem1niscence merged 8 commits into
mainfrom
issue-#1
Jan 20, 2025
Merged

Issue #1#3
rem1niscence merged 8 commits into
mainfrom
issue-#1

Conversation

@rem1niscence

@rem1niscence rem1niscence commented Jan 20, 2025

Copy link
Copy Markdown
Collaborator
  • Display form placeholders on a lighter weight and a bit more opaque, to better differentiate from user input
  • Sanitizes text input preventing " and `\t'.
  • Format number input by adding commas as thousands separator

This is how it looks for placeholder and number values:

image

andrewnguyen22
andrewnguyen22 requested changes Jan 20, 2025
View reviewed changes

@andrewnguyen22 andrewnguyen22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and super clean work!

The only thing that's an issue is that the default values don't have the commas property

image

@rem1niscence

rem1niscence commented Jan 20, 2025

Copy link
Copy Markdown
Collaborator Author

on it!

@rem1niscence

rem1niscence commented Jan 20, 2025

Copy link
Copy Markdown
Collaborator Author

fix submitted, check again!

@andrewnguyen22

andrewnguyen22 commented Jan 20, 2025

Copy link
Copy Markdown
Collaborator
image Can you revert showing 0 as the default tx fee

Other than that it looks great!

@andrewnguyen22 andrewnguyen22 self-assigned this Jan 20, 2025
@andrewnguyen22
andrewnguyen22 self-requested a review January 20, 2025 18:24
@rem1niscence

rem1niscence commented Jan 20, 2025

Copy link
Copy Markdown
Collaborator Author

done, all good now 🔥

@rem1niscence
rem1niscence merged commit 40a0011 into main Jan 20, 2025
@andrewnguyen22 andrewnguyen22 mentioned this pull request Jan 20, 2025
Closed
@andrewnguyen22
andrewnguyen22 deleted the issue-#1 branch January 28, 2025 14:10
Makaveli912 added a commit to Makaveli912/praxis-market that referenced this pull request May 23, 2026
@Makaveli912
fix: address all Deepseek audit findings
4bdfbf5 
Finding canopy-network#1 (CRITICAL): TEST_MODE now reads PRAXIS_TEST_MODE env var
- Defaults to false — mainnet-safe out of the box
- Enable with: PRAXIS_TEST_MODE=true ./go-plugin
- Added os import to constants.go

Finding canopy-network#2 (LOW-MEDIUM): Deprecation notice on handler_resolve_market.go
- Clear warning: DO NOT re-register — bypasses PORS mechanism
- File retained for proto interface; scheduled for future removal

Finding canopy-network#3 (LOW): KeyForMarketPool confirmed at keys.go:184 — false alarm

Finding canopy-network#4 (COSMETIC): Fixed handleFSMResponse comment mismatch
SocratesDz referenced this pull request in SocratesDz/canopy Jun 19, 2026
@SocratesDz @claude
docs(canoliq): mark v1.1 whitepaper/tokenomics discrepancies resolved…
88d803a 
… in v1.2

Append a verification section (against canoLiq_Whitepaper_v1.2.pdf and
canoLiq_Tokenomics_v1.2.pdf) confirming all four doc-vs-doc findings are
fixed in v1.2:

  #1 Validator cliff — WP corrected to 12mo (and v1.2 §5.3 calls out the
     change explicitly: 'The 12-month cliff (not 6 months)…')
  #2 Community & Airdrops — WP corrected to 'Snapshot-based linear;
     12-month distribution' and rationale disambiguates against Dev Grants
  #3 6-month subsidy reduction — both docs now say 30–45% (Tokenomics
     moved from 33–45%)
  #4 Buyback default — Tokenomics now names 'Burn' as the default in
     three places (§1 overview, §3.2 fee-dist table, §4.1 buyback engine)

The Community & Airdrops on-chain vesting gap (genesis bucket cliff/vest =
0/0 vs docs' 12-month daily emission) is unchanged in v1.2 — it is a
distributor-vs-genesis question, not a doc-vs-doc one, and remains open
pending confirmation that the bucket recipient is a controlled distributor.

Adds a top-of-doc status banner pointing at the new section and marks the
original 'Recommended actions' list as superseded.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
SocratesDz referenced this pull request in SocratesDz/canopy Jun 19, 2026
@SocratesDz @claude
docs(canoliq): close discrepancy report — community-airdrops distribu…
09a20df 
…tor confirmed

Dev team confirmed (2026-06-18) that the bucket #3 recipient now in
genesis.testnet.json (7d941def…e478) is a controlled distributor that
enforces the 12-month linear emission described by the v1.2 docs. The
on-chain 'cliffMonths: 0, vestMonths: 0' on that bucket is therefore
intentional and not a code/doc conflict.

- Top status banner: 'verified' → 'verified + closed'; drops the
  'remains open pending dev confirmation' clause.
- v1.1 'Additional code/doc gap' bullet: appended a resolution line so
  the historical context is preserved alongside the closure.
- v1.2 resolution section: renamed 'Still open' → 'closed 2026-06-18',
  cites the specific bucket-3 address, and declares the whole report
  closed.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
SocratesDz referenced this pull request in SocratesDz/canopy Jun 19, 2026
@SocratesDz @claude
docs(canoliq): clarify off-chain emission for Liquidity / Community b…
48342b8 
…uckets

Two adjacent touch-ups prompted by the dev-team confirmation that recorded
0/0 vesting on buckets #2 and #3 is intentional (the schedule lives off-chain
in a distributor address).

plugin/go/canoliq/README.md (Genesis configuration section):
  Add a callout next to the 'cliffMonths == 0 && vestMonths == 0 mints
  immediately' rule warning that Liquidity Incentives and Community & Airdrops
  *intentionally* carry 0/0 because their tokenomics schedule is enforced by
  the bucket recipient; otherwise the allocation goes liquid at TGE. Also
  notes that DAO Treasury and Dev Grants have no schedule by design.

docs/canoliq-testnet-deployment-readiness.md (Section A):
  Mark addresses as supplied (✅ 2026-06-18) and fill in the seven
  bucket-recipient addresses (truncated with prefix…suffix). Rename the
  vesting column to 'On-chain vesting', mark buckets #2 and #3 as
  'none (off-chain ⚠️)', and add a callout pointing at the discrepancy
  report for the audit trail.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
SocratesDz referenced this pull request in SocratesDz/canopy Jun 19, 2026
@SocratesDz @claude
docs(canoliq): sweep readiness doc — surface §B–§E status, mark §A wired
4c1442e 
The 'Data required' section was written when nothing had landed. Audit the
actual state of plugin/go/canoliq/genesis.testnet.json and
canoliq-config.testnet.json and surface where each subsection stands.

- Top of §🔑: add a five-row status snapshot table so the coverage is visible
  without reading every subsection (A ✅, B/C/D/E ⏳).
- §B / §C / §D: add '⏳ pending' badges to the headings and call out the
  exact placeholder values currently in the files, so a reader doesn't have
  to grep to see what's left.
- §E: per-bullet '⏳ pending' badges plus a '(Closed 2026-06-18)' line
  recording the dev confirmation that bucket #2/#3 recipients are
  controlled distributors (the only off-chain fact that has actually moved).
- Workstream 1 intro: 'once A–D arrive' → 'once B–D arrive (A already wired)'
  and strike-through the bucket-address bullet, pointing at commit f3fa10e.

No change to §B–§D mechanics; this is hygiene to keep the doc honest about
what's done.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ezeike added a commit that referenced this pull request Aug 4, 2026
@ezeike
test(fsm): prefix-leak regression test for account change capture
3ecaa24 
Adds an integration-level test proving AccountChangeCollector captures only
account-prefixed keys when a real applied block also writes POOL and VALIDATOR
entries via BeginBlock/EndBlock committee-reward machinery (not a direct Set
call, which TestStateMachine_SetDoesNotHookNonAccountKeys already covers).

newTestPoolAndValidatorTouchingChain extends the newTestAccountDeltaChain
pattern: validator #3 (the certificate's reward recipient) is flipped to
Compound=true before block 4 commits, so block 5's committee reward routes
through UpdateValidatorStake/SetValidator instead of the default
non-compounding AccountAdd-to-output path. The unconditional DAO pool mint
in BeginBlock supplies the pool write.

The test verifies -- rather than assumes -- that the measured block writes
both a pool and a validator entry (strict pre/post balance increases), then
asserts every captured account entry is address-sized, is not validator #3's
(proven-written) address, and round-trips to the live KeyForAccount value.
Verified the validator-address check specifically catches a
bytes.HasPrefix(k, ValidatorPrefix()) regression by temporarily broadening
the collector hook and confirming the test fails, then reverting.

Per re-scoping from the task-11 brief: the brief's other proposed test
(reward/slash capture proving force-include redundancy) is intentionally
NOT implemented -- that premise was found false by review; force-include
remains necessary and is already covered by
TestIndexerBlobsCached_ForceIncludesUnwrittenRewardSlashAccounts
(cmd/rpc/query_test.go) and TestAccountDelta_MatchesOldFullScanAndDiff
(fsm/indexer_test.go, Task 10).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewnguyen22 andrewnguyen22 andrewnguyen22 approved these changes

Assignees

@andrewnguyen22 andrewnguyen22

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rem1niscence @andrewnguyen22