Creating the Wallet Directory - #1
Merged
Merged
Conversation
…eatures Implements the Canton Foundation's Featured Wallets Program (renamed here to "Wallet Directory" to avoid implying endorsement/promotion) as a structured, low-maintenance repo: - WALLET_DIRECTORY.md: generated summary table (two sections -- primary Canton Network features, then everything else), linking each claim to its evidence. - wallets/_feature_registry.yaml: single source of truth for feature ids, names, categories, and suggested tests. - wallets/<wallet-name>.yaml: one self-attestation file per wallet provider, following wallets/TEMPLATE.yaml. - proofs/<wallet-name>/: one folder per wallet holding self-attestation and third-party-attestation evidence files, per proofs/_TEMPLATE/*. Verification model: self-attested (checkmark, linked to evidence), independently verified (shield + verifier name), disputed as unsupported (cross + verifier name, when a verifier shows a claim doesn't hold up), or not supported (optionally with a stated reason). A handful of generic, non-Canton-specific capabilities (key recovery, threshold signing, compliance, etc.) are marked self_attested_only and have no proof/verification mechanism at all. scripts/generate_table.py has zero dependencies -- it includes its own minimal YAML reader scoped to this repo's schema, so regenerating the page never requires pip/venv. A GitHub Action (.github/workflows/verify-wallet-directory.yml) regenerates and diffs the page on every PR touching wallets/ or scripts/. CONTRIBUTING.md is the single file explaining the whole process for both wallet providers and third-party verifiers. Also: split the combined "CIP-0103 dApp API / Wallet Connect" feature into two independently provable features; removed batch_airdrops (internal-only consideration); renamed featured_since to added.
davidrichards-da
requested review from
hythloda,
isegall-da,
omaiko-intellecteu,
stas-sbi,
tkatrichenko and
waynecollier-da
July 8, 2026 10:42
The verify-wallet-directory.yml check regenerates WALLET_DIRECTORY.md and
diffs it against the committed version to catch staleness. But the file
embedded a wall-clock 'Last generated {timestamp}' line, so a fresh
regeneration in CI would always differ from whatever was committed by the
minute -- the check could never pass, regardless of whether the actual
data was in sync. Removing the timestamp makes the output a pure,
deterministic function of wallets/*.yaml + the registry, which is what the
diff check actually needs. Also drops the now-unused datetime import (and
its deprecation warning).
hythloda
approved these changes
Jul 8, 2026
hythloda
left a comment
hythloda
left a comment
Contributor
There was a problem hiding this comment.
I did not test this locally but looks complete to be and did an AI review that found no errors (trying to streamline). Risk of error is low so think ship and test in GH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Canton Foundation's Wallet Directory Program
Verification model: self-attested (checkmark, linked to evidence), independently verified (shield + verifier name), disputed as unsupported (cross + verifier name, when a verifier shows a claim doesn't hold up), or not supported (optionally with a stated reason).
scripts/generate_table.py has zero dependencies -- it includes its own minimal YAML reader scoped to this repo's schema.
(.github/workflows/verify-wallet-directory.yml) regenerates and diffs the page on every PR touching wallets/ or scripts/.
CONTRIBUTING.md is the single file explaining the whole process for both wallet providers and third-party verifiers.