Gate inline snippet sources in CI - #1262
Closed
danielporterda wants to merge 1 commit into
Closed
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position
7 of 7. Depends on #1261 and completes GitHub stack #1263.
What changed
*.source.mdxcontract and rejects committed local refs with exact page/line remediation.snippets:check-all; it is a no-op until the first production page opts in.<Else>.This stack deliberately does not migrate a live page. A safe pilot needs a real upstream change and release boundary; mixing that content decision into the machinery stack would make both harder to review.
Validation
npm run test:inline-snippets— 49 passednpm run test:external-snippets— 5 passednpm run snippets:validate— 0 opted-in pages, passednpm run snippets:check-all— 0 opted-in pages, passedruff check scripts/snippets tests/test_inline_snippet_*.pymypy scripts/snippetscd docs-main && npx mint validate— passedorigin/main: x2mdx whitespace fixtures and the existing Wallet navigation expectation. The stack adds no new full-suite failure.git diff --checkpasses.Review focus
Please focus on CI cost/credentials, fail-closed behavior when GitHub evidence is unavailable, and whether the first page migration should be a separate follow-up as proposed.