Parse immutable snippet source refs - #1296
Closed
danielporterda wants to merge 1 commit into
Closed
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
Contributor
Author
|
Closing this draft because the inline release-aware snippet stack is being retired. The branch remains available if its implementation is needed later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a pure parser for immutable snippet sources expressed as complete GitHub blob URLs.
It accepts only
https://github.com/<owner>/<repo>/blob/<40-character-commit>/<path>, normalizes the commit hash to lowercase, and returns repository, commit, and path as a typed reference. Branch names, abbreviated hashes, missing paths, query strings, fragments, and non-GitHub hosts do not parse.This PR does not parse candidate PR refs or local refs, check repository membership, or validate whether the parsed path is safe.
Why
Each supported source-reference form should be independently reviewable before they are combined into the
<Snippet>semantic validator.Validation
python -m pytest tests/test_immutable_snippet_source_parser.py(7 passed)python -m ruff check scripts/snippets/model.py scripts/snippets/references.py tests/test_immutable_snippet_source_parser.pypython -m mypy scripts/snippets/model.py scripts/snippets/references.pygit diff --check