Parse pull request snippet refs - #1297
Closed
danielporterda wants to merge 1 commit into
Closed
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
Contributor
Author
|
Closing this draft because the inline release-aware snippet stack is being retired. The branch remains available if its implementation is needed later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a pure parser for candidate snippet sources expressed as canonical GitHub pull-request URLs.
It accepts only
https://github.com/<owner>/<repo>/pull/<positive-number>and returns repository identity plus the PR number as a typed reference. Alternate hosts, zero or non-numeric IDs, trailing slashes, subpages, and query strings do not parse.This PR does not parse the candidate file path, require an enclosing
<IfVersion>, or compare the candidate with a condition. Those are separate semantic layers.Why
Candidate references have a different lifecycle and shape from immutable blob references, so their syntax should be independently reviewable.
Validation
python -m pytest tests/test_pull_request_snippet_source_parser.py tests/test_immutable_snippet_source_parser.py(14 passed)python -m ruff check scripts/snippets/model.py scripts/snippets/references.py tests/test_pull_request_snippet_source_parser.pypython -m mypy scripts/snippets/model.py scripts/snippets/references.pygit diff --check