Validate IfVersion attributes - #1306
Closed
danielporterda wants to merge 1 commit into
Closed
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
Contributor
Author
|
Closing this draft because the inline release-aware snippet stack is being retired. The branch remains available if its implementation is needed later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validates the attributes on one opening
<IfVersion>tag and produces a typed condition when they are valid.It rejects unknown attributes, requires a complete registered GitHub repository URL, and requires
containsPullRequestto be a positive integer expression. It does not apply nesting rules or inspect any enclosed<Snippet>.Why
Condition identity is separate from conditional structure and from candidate/snippet matching.
Validation
python -m pytest tests/test_if_version_attribute_validation.py(7 passed)python -m ruff check scripts/snippets/model.py scripts/snippets/validation.py tests/test_if_version_attribute_validation.pypython -m mypy scripts/snippets/model.py scripts/snippets/validation.pygit diff --check