Skip to content

Resolve merged candidate snippets - #1333

Closed
danielporterda wants to merge 1 commit into
snippet-resolve-candidate-previewfrom
snippet-resolve-merged-candidate
Closed

Resolve merged candidate snippets#1333
danielporterda wants to merge 1 commit into
snippet-resolve-candidate-previewfrom
snippet-resolve-merged-candidate

Conversation

@danielporterda

@danielporterda danielporterda commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What changed

  • resolves a merged candidate through GitHub's merge commit
  • rejects an open candidate outside preview with an explicit error

Why

Squash-merged source PRs cannot provide their final commit hash before merge. The authored PR identity remains stable; production resolution uses the merge commit GitHub reports afterward.

Validation

  • 5 focused resolver tests
  • Ruff
  • mypy
  • git diff --check

Not included

  • release containment
  • local checkout resolution
  • GitHub HTTP implementation

Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
@danielporterda

Copy link
Copy Markdown
Contributor Author

Closing this draft because the inline release-aware snippet stack is being retired. The branch remains available if its implementation is needed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant