feat: move isDevnet check to wallet-sdk

[fayi-da]

Part of #2149

• move isDevNet check to wallet-sdk
• make Tap amulet only operation
• delete unused services and dependencies

[Copilot]

Pull request overview

This PR continues the #1795 “wallet-sdk replacement” work by shifting DevNet detection and DevNet tap behavior to use @canton-network/wallet-sdk, while removing the now-unneeded Portfolio service abstraction and related dependencies in the example app.

Changes:

• Add AmuletNamespace.isDevNet() to the wallet SDK and cover it with a unit test.
• Make DevNet tap in the Portfolio example an “Amulet-only” operation (no instrument selection), wiring taps through wallet-sdk + submitViaProvider.
• Remove unused Portfolio service/context modules and drop @canton-network/core-splice-client from the Portfolio example’s dependencies.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
yarn.lock	Removes an unused workspace dependency entry related to the Portfolio example’s dependency cleanup.
sdk/wallet-sdk/src/wallet/namespace/amulet/namespace.ts	Adds isDevNet() to the Amulet namespace, delegating to amuletService.
sdk/wallet-sdk/src/wallet/namespace/amulet/amulet.test.ts	Adds a unit test for the new isDevNet() wrapper.
sdk/wallet-sdk/src/wallet/init/initializedSDK.ts	Documents/retains the validator-proxy behavior when validatorUrl is configured.
examples/portfolio/tests/utils.ts	Updates tap test helper to assert fixed “Amulet” instrument rather than selecting an instrument.
examples/portfolio/tests/settings-next.spec.ts	Updates tap amount expectation to include fractional precision.
examples/portfolio/tests/next-utils.ts	Updates Next UI tap helper to assert fixed “Amulet” instrument rather than selecting an instrument.
examples/portfolio/src/services/resolve.ts	Removes Amulet service resolver plumbing; keeps only token-standard service resolution (but leaves some dead code as noted).
examples/portfolio/src/services/portfolio-service.ts	Deletes the PortfolioService interface (no longer used).
examples/portfolio/src/services/portfolio-service-implementation.ts	Deletes the Portfolio service implementation (tap/isDevNet now handled via wallet-sdk).
examples/portfolio/src/main.tsx	Removes PortfolioProvider from the app tree.
examples/portfolio/src/hooks/useIsDevNet.ts	Simplifies hook to use wallet-sdk-based query options.
examples/portfolio/src/hooks/query-options.ts	Moves isDevNet query to wallet-sdk (but currently keys off the wrong validatorUrl as noted).
examples/portfolio/src/hooks/query-keys.ts	Replaces the global isDevNet key with a validator-specific key.
examples/portfolio/src/contexts/PortfolioProvider.tsx	Deletes the provider (no longer needed).
examples/portfolio/src/contexts/PortfolioContext.tsx	Deletes the context and usePortfolio hook (no longer needed).
examples/portfolio/src/components/tap-settings.tsx	Makes Settings-page tap an Amulet-only operation executed via wallet-sdk.
examples/portfolio/src/components/settings/devnet-tap-dialog.tsx	Makes dialog tap Amulet-only and executes via wallet-sdk; updates the UI accordingly.
examples/portfolio/package.json	Drops @canton-network/core-splice-client from the Portfolio example’s dependencies.

Comments suppressed due to low confidence (1)

examples/portfolio/src/services/resolve.ts:51

• ledgerClient singleton is now dead code: it is never assigned/returned anywhere and is only cleared. Keeping this around makes the resolver harder to understand and can trip unused-code checks.

// Global, but so is the dApp SDK.
const ledgerClient: { singleton: LedgerClient | undefined } = {
    singleton: undefined,
}
const tokenStandardService: { singleton: TokenStandardService | undefined } = {
    singleton: undefined,
}
// Can be called to reset clients on disconnects.
export const clear = () => {
    ledgerClient.singleton = undefined
    tokenStandardService.singleton = undefined
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

examples/portfolio/src/hooks/query-options.ts:167

• The non-TLS validatorUrl warning is now emitted only inside the isDevNet query. Other flows (e.g. tapping via sdk.amulet.tap(...)) can still use an http: validator endpoint without ever triggering this warning if useIsDevNet isn't queried. Consider moving this check to a central place that always runs when the SDK is configured (e.g. useWalletSdk during walletSdk.SDK.create, or config validation) so it consistently covers all validator interactions.

            const url = new URL(validatorUrl)
            if (url.protocol === 'http:') {
                logger.warn(
                    { validatorUrl: url.toString() },
                    'Using a non-TLS validator endpoint. This is acceptable only in trusted environments. Set validatorUrl in portfolio config to an HTTPS endpoint if the validator API is reachable over an untrusted network.'

[rukmini-basu-da]

thanks!