chore: portfolio qol fixes - #2207
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves the Portfolio example’s UX and reliability around wallet connectivity and transaction history labeling, addressing remaining non-ideal behaviors tracked under #1795.
Changes:
- Refactors
ConnectionProviderinto focused hooks and expands query invalidation to refresh holdings after executed transactions. - Updates transaction history activity labeling to distinguish DevNet faucet taps, rewards collection, and traffic purchases.
- Makes the “next” transfer instrument selector resilient to missing instrument metadata (symbol/name/decimals) and adjusts types accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/portfolio/tests/transaction-history.spec.ts | Updates E2E expectations for faucet transactions to display “DevNet tap”. |
| examples/portfolio/src/contexts/ConnectionProvider.tsx | Refactors connection logic into hooks; adds holdings invalidation on executed tx events. |
| examples/portfolio/src/components/next/transfer-types.ts | Allows decimals to be undefined to match potentially missing instrument metadata. |
| examples/portfolio/src/components/next/instrument-select.tsx | Adds fallbacks when holding.instrument metadata is absent. |
| examples/portfolio/src/components/dashboard/transaction-history-utils.ts | Adds richer activity labels for Merge/Split rewards, Mint (DevNet tap), and Burn (traffic purchase). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexmatson-da
previously approved these changes
Jul 28, 2026
fayi-da
force-pushed
the
fayi/1795-qol-fixes
branch
from
July 29, 2026 10:39
59044f8 to
791e8a0
Compare
fayi-da
force-pushed
the
fayi/1795-qol-fixes
branch
2 times, most recently
from
July 29, 2026 11:29
7dfbe03 to
2c185a5
Compare
fayi-da
enabled auto-merge (squash)
July 29, 2026 14:03
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
fayi-da
force-pushed
the
fayi/1795-qol-fixes
branch
from
July 29, 2026 15:41
2c185a5 to
8bd448d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
examples/portfolio/src/components/next/instrument-select.tsx:55
- The fallback label for instruments without metadata uses only
holding.instrumentId.id, but elsewhere in the portfolio UIid || adminis used to avoid rendering an empty label whenidis missing/blank. Consider applying the same fallback here for bothsymbolandname.
symbol: instrument?.symbol ?? holding.instrumentId.id,
name: instrument?.name ?? holding.instrumentId.id,
mjuchli-da
approved these changes
Jul 30, 2026
mateuszpiatkowski-da
pushed a commit
that referenced
this pull request
Aug 10, 2026
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
mateuszpiatkowski-da
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com> Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some issues in #2149