Clears the list of processes before SaveAll().#83
Open
avengerx wants to merge 1 commit intocaoyue:devfrom
Open
Clears the list of processes before SaveAll().#83avengerx wants to merge 1 commit intocaoyue:devfrom
avengerx wants to merge 1 commit intocaoyue:devfrom
Conversation
When rebuilding the list of processes from SaveAll(), removes everything to ensure no leftovers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rebuilding the list of processes from SaveAll(), removes everything to ensure no leftovers.
Without this, minimized windows get restored when calling restore, if they once were not minimized when running a SaveAll().
Warning: This might wipe manually configured windows if the user is accustomed to configure inactive windows manually and call SaveAll to save all other windows. It is advised such cases to be saved in different profiles.
To reproduce the issue this (hopefully) fixes:
With this fix, in step 3, the window will be removed from the list of Processes.
Perhaps a better (much better) fix would be to no longer skip minimized windows, but save their "restored" (non-minimized nor maximized) dimensions and their minimized/maximized state, and then also take the state in consideration during restoreAll. When windows are moved to a smaller screen, even if minimized, their sizes are shrunk when restoring them even after the bigger displays have been turned back on.
This might conflict with pr #82, TrayContext.cs:392. In my side I just use the conflicting lines in this sequence:
But the order shouldn't affect anything.