Skip to content

refactor: use GraphQL Type APIs instead of internal properties #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2023
Merged

refactor: use GraphQL Type APIs instead of internal properties #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bdc62d
refactor: use GraphQL Type APIs instead of internal properties
schwma Jan 3, 2023
1b03d85
Use Type API in test util
schwma Jan 4, 2023
1ed5bcb
Merge branch 'main' into use-type-apis
schwma Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/resolvers/parse/ast/enrich.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ const _traverseArgumentOrObjectField = (info, argumentOrObjectField, _fieldOr_ar
argumentOrObjectField.value = substituteVariable(info, value)
break
case Kind.LIST:
_traverseListValue(info, value, type._fields)
_traverseListValue(info, value, type.getFields())
break
case Kind.OBJECT:
_traverseObjectValue(info, value, type._fields)
_traverseObjectValue(info, value, type.getFields())
break
}
}
Expand All @@ -60,7 +60,7 @@ const _getTypeFrom_fieldOr_arg = _field => {
const _traverseField = (info, field, _field) => {
if (field.selectionSet) {
const type = _getTypeFrom_fieldOr_arg(_field)
_traverseSelectionSet(info, field.selectionSet, type._fields)
_traverseSelectionSet(info, field.selectionSet, type.getFields())
}

field.arguments.forEach(arg => {
Expand All @@ -79,8 +79,8 @@ module.exports = info => {
const deepClonedFieldNodes = JSON.parse(JSON.stringify(info.fieldNodes))

const rootTypeName = info.parentType.name
const rootType = info.schema._typeMap[rootTypeName]
_traverseFieldNodes(info, deepClonedFieldNodes, rootType._fields)
const rootType = info.schema.getType(rootTypeName)
_traverseFieldNodes(info, deepClonedFieldNodes, rootType.getFields())

return deepClonedFieldNodes
}
2 changes: 1 addition & 1 deletion test/util/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const fakeInfoObject = (document, schema, parentTypeName, variables) => {
return {
fieldNodes: operationDefinition.selectionSet.selections,
schema,
parentType: schema._typeMap[parentTypeName],
parentType: schema.getType(parentTypeName),
variableValues: { ...variables },
fragments
}
Expand Down