Filter Implementations which need missing required TypeInstance injection #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
added
enhancement
pkosiec
requested review from
Trojan295,
lukaszo,
mszostok and
platten
as code owners
pkosiec
force-pushed
the
filter-impl-without-inject
branch
2 times, most recently
from
39fbe73 to
2dd9eb0
Compare
pkosiec
force-pushed
the
filter-impl-without-inject
branch
from
2dd9eb0 to
2d62a42
Compare
pkosiec
force-pushed
the
filter-impl-without-inject
branch
from
a8c9d17 to
b3ff94a
Compare
pkosiec
commented
Aug 24, 2021
mszostok
approved these changes
Aug 25, 2021
Collaborator
|
I approved that as it works and it lgtm. I'm only not sure about the API and it's behaviour but we can discuss that offline. |
pkosiec
force-pushed
the
filter-impl-without-inject
branch
from
b3ff94a to
c00bbf2
Compare
mszostok
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Notes
This pull request bases on #452. Once #452 is merged, this PR will be rebased.Done
Testing
No manual testing needed, as modified integration tests and unit tests (including renderer one) cover this case.
Related issue(s)
#438