Skip to content

Conversation

@Trojan295
Copy link
Contributor

@Trojan295 Trojan295 commented Sep 1, 2021

Description

Changes proposed in this pull request:

  • Save rendered workflow, even if linting fails

Testing

  1. Apply a not working change to an Implementation manifest, e.g. the following diff to the manifests:
diff --git a/manifests/implementation/bitnami/postgresql/install.yaml b/manifests/implementation/bitnami/postgresql/install.yaml
index 99ed9d4..17c5a30 100644
--- a/manifests/implementation/bitnami/postgresql/install.yaml
+++ b/manifests/implementation/bitnami/postgresql/install.yaml
@@ -63,7 +63,7 @@ spec:
             outputs:
               artifacts:
                 - name: postgresql
-                  from: "{{steps.helm-install.outputs.artifacts.additional}}"
+                  from: "{{steps.helm-installed.outputs.artifacts.additional}}"
             steps:
               - - name: create-helm-args
                   capact-action: jinja2.template
  1. Populate the manifests
  2. Create an Action with the wrong Implementation:
# /tmp/psql-params.yaml
superuser:
  username: damian
  password: sup3rs3cr3t
defaultDBName: postgres
capact action create \
  cap.interface.database.postgresql.install \
  --name psql \
  --parameters-from-file /tmp/psql-params.yaml
  1. The Action rendering should fail, but the rendered workflow should be still saves in the Action CR status

Related issue(s)

Resolves #469

@Trojan295 Trojan295 added area/engine Relates to Engine enhancement New feature or request labels Sep 1, 2021
@Trojan295 Trojan295 merged commit 881d216 into capactio:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/engine Relates to Engine enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save rendered action even after a failed Argo lint

2 participants