Show sudo password prompt #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszo
requested review from
Trojan295,
mszostok,
pkosiec and
platten
as code owners
mszostok
approved these changes
Sep 5, 2021
Collaborator
mszostok
left a comment
mszostok
left a comment
There was a problem hiding this comment.
Tested 3 scenarios:
- empty /etc/hosts
- no certs
- no certs + empty /etc/hosts
worked properly in all of them 👍
Comment on lines
30
to
31
| cmd.Stdout = os.Stdout | ||
| cmd.Stderr = os.Stderr |
Collaborator
There was a problem hiding this comment.
I tried to use textio.NewPrefixWriter(w, "\t") lib but with no luck and as discussed f2f we will improve "UI" later if necessary. For now it's already an improvement in UX 👍
Co-authored-by: Mateusz Szostok <szostok.mateusz@gmail.com>
Co-authored-by: Mateusz Szostok <szostok.mateusz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
gateway.capact.localentry from/etc/hostsmake build-tool-clicapactcommand without installing any componentscapact install --install-component=""Related issue(s)
Closes #412