-
Notifications
You must be signed in to change notification settings - Fork 19
Add local registry support for k3d environment #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb51fcb to
89e418c
Compare
d940c2f to
5e03ea4
Compare
Contributor
|
One thing I noticed: if I don't have the ❯ capact env create k3d --enable-registry
Creating cluster dev-capact...
✗ Creating local registry under /home/damian/.config/capact/local_registry
Error: Error response from daemon: No such image: registry:2Executing |
Trojan295
reviewed
Sep 7, 2021
489dfbb to
6305a68
Compare
Collaborator
Author
|
No the image is pulled when needed 👍 For now, I added TODO comment for supporting port change, as I run into an issue with it and wasn't able to solve it with a given timebox |
6305a68 to
1c88042
Compare
Trojan295
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we build images on local machine, archive them, mount to kind/k3d cluster and load into cluster.
This PR adds support for local registry, so we build images on local machine and push them to local registry.
As a result, we re-use native docker support for pushing only changed layers and also re-use layers between images. Thanks to that, we reduce time spent on sharing images between localhost and k3d cluster in all scenarios (install/upgrade and when the cluster is deleted as the local registry stores data on localhost).
K3d and local registry containers are connected with the same network.
Changes proposed in this pull request:
capact env create k3d --enable-registrycapact install --environment k3d --enable-registrycapact env delete k3dv=2not specified, output is more concise and consistent.fmt.SprintfKind with loading images

Install:
Upgrade: (no changes)
K3d with local registry

Install:
Upgrade (no changes):
https://asciinema.org/a/432775
Related issue(s)