Enable CORS for Capact Gateway Ingress #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
requested review from
mkuziemko,
mszostok and
platten
as code owners
pkosiec
force-pushed
the
configure-cors
branch
from
b5a81ba to
9ae12bc
Compare
mszostok
reviewed
Nov 30, 2021
Collaborator
mszostok
left a comment
mszostok
left a comment
There was a problem hiding this comment.
Personally, I would vote to allow all origins only in local development. It can be easily added to our CLI overrides:
capact/internal/cli/capact/defaults.go
Lines 58 to 61 in 3ba7ad1
mszostok
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
It enables Gateway GraphQL API to be consumed by UIs deployed anywhere by default only for local installation.