Add @cap-js/sqlite as dev dependency#52
Closed
rjayasinghe wants to merge 2 commits into
Closed
Conversation
`cds export --data` triggers `cds.deploy('*')`, which requires a
database implementation. cds-dk 9 bundled `@cap-js/sqlite`; cds-dk 10
no longer does, so the plugin fails to resolve it from the project
root and `cds.export` in `apis/data-service` aborts with
`Cannot find module '@cap-js/sqlite'`.
Declaring it as a dev dependency is the documented cds-dk 10
migration.
Contributor
|
Replaced by #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@cap-js/sqlite@^2as a dev dependency to complement the cds-dk 10 upgrade.package-lock.json.Why
cds export --data(invoked fromapis/data-service/pom.xml) triggerscds.deploy('*')inside cds-dk, which requires a database implementation. cds-dk 9 bundled@cap-js/sqlite; cds-dk 10 no longer does. Without this dev dep,cds.exportaborts with:Note
This is one of several fixes needed for the CAP 5 upgrade. Additional bugs in
cds-services(cds-maven-plugin) andcds-dk(hardcoded plugin version) block the root-levelmvn compilewhencds export -4 mvnis used. Those need to be resolved upstream before this branch can produce a green build end-to-end.Test plan
npm installsucceedsmvn -pl apis/data-service -am package -DskipTestscompletes pastcds.export(verified locally)