refactor: add py3.12 and py3.13 to tests by JGSweets · Pull Request #1212 · capitalone/DataProfiler

JGSweets · 2026-07-06T15:45:51Z

this pr:

refactors to utilize py3.12 and py3.13
many updates for mypy consistency across py3.10->py3.13

JGSweets · 2026-07-06T15:59:41Z

@shania-m I'm updating the tests here to run py3.12 and py3.13
This should help future proof. However, I think we should remove py3.10 soon

We would love a release of the DP as soon as possible after this merges! Thanks!

JGSweets · 2026-07-06T16:34:51Z

            other1._median_abs_dev_is_enabled and other2._median_abs_dev_is_enabled
        )

+    @property


biggest change is here. but it matches the other class functionalities of being properties and not methods.

JGSweets · 2026-07-06T16:35:19Z

        :return:
        """
-        profile = NumericStatsMixin.profile(self)
+        profile = cast(dict, NumericStatsMixin.profile.__get__(self, type(self)))


you can see the change have an effect here from making it a property instead of a method

JGSweets · 2026-07-06T16:35:25Z

        :return:
        """
-        return NumericStatsMixin.profile(self)
+        return cast(dict, NumericStatsMixin.profile.__get__(self, type(self)))


you can see the change have an effect here from making it a property instead of a method

JGSweets · 2026-07-06T16:35:33Z

        :rtype: Profile
        """
        calcs_dict_keys = self._NumericStatsMixin__calculations.keys()
-        profile = self.profile()


you can see the change have an effect here from making it a property instead of a method

JGSweets · 2026-07-06T16:36:27Z

        pass

    def _need_to_reconstruct_model(self) -> bool:
-        pass


a change, but should be inconsequential and matches the typing

previously would return None now it returns False

JGSweets · 2026-07-06T16:36:36Z

        pass

    def _need_to_reconstruct_model(self) -> bool:
-        pass


a change, but should be inconsequential and matches the typing

previously would return None now it returns False

JGSweets · 2026-07-06T19:28:31Z

-    MCM[:, 1, 0] = np.sum(
-        conf_matrix * (np.ones(num_labels) - np.eye(num_labels)), axis=1
+    non_diagonal_mask = cast(
+        np.ndarray, np.logical_not(np.eye(num_labels, dtype=bool)).astype(np.int64)


small change here

JGSweets · 2026-07-06T19:32:29Z

    strategy:
      matrix:
-        python-version: ["3.10", "3.11"]
+        python-version: ["3.10", "3.11", "3.12", "3.13"]


added newest python

JGSweets · 2026-07-06T19:32:56Z


    steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v4.3.1


C1 requires commit sha? was denied v4 and v5 on first commit

JGSweets · 2026-07-06T19:33:06Z

@@ -1,5 +1,5 @@
 [tox]
-envlist = py39, py310, py311, pypi-description, manifest, precom
+envlist = py310, py311, py312, py313, pypi-description, manifest, precom


remove old and add new

JGSweets · 2026-07-06T19:33:19Z

 line_length=88

 [mypy]
+files = dataprofiler


mypy will actually utilize this in our testing now

JGSweets · 2026-07-06T19:33:27Z

  # https://github.com/pre-commit/mirrors-mypy
  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.982
+    rev: v1.11.2


updated mypy

JGSweets · 2026-07-06T19:33:44Z

+    rev: v1.11.2
    hooks:
      - id: mypy
-        exclude: (^dataprofiler/tests/|^resources/|^examples|venv*/|versioneer.py|dataprofiler/_version.py|_docs/)


this exclude is for pre-commit, but mypy doesn't utilize it hence the updates here

socket-security · 2026-07-06T20:54:40Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	pypi/pyarrow@24.0.0 ⏵ 23.0.1					⁺³¹

View full report

socket-security · 2026-07-06T20:54:42Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		License policy violation: pypi `pyarrow` License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) From: requirements.txt → `pypi/pyarrow@23.0.1` ℹ Read more on: This package \| This alert \| What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore pypi/pyarrow@23.0.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		License policy violation: pypi `pyarrow` License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) From: requirements.txt → `pypi/pyarrow@23.0.1` ℹ Read more on: This package \| This alert \| What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore pypi/pyarrow@23.0.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		License policy violation: pypi `pyarrow` License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) From: requirements.txt → `pypi/pyarrow@23.0.1` ℹ Read more on: This package \| This alert \| What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore pypi/pyarrow@23.0.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		License policy violation: pypi `pyarrow` License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) From: requirements.txt → `pypi/pyarrow@23.0.1` ℹ Read more on: This package \| This alert \| What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore pypi/pyarrow@23.0.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		License policy violation: pypi `pyarrow` License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) From: requirements.txt → `pypi/pyarrow@23.0.1` ℹ Read more on: This package \| This alert \| What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore pypi/pyarrow@23.0.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		License policy violation: pypi `pyarrow` License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) From: requirements.txt → `pypi/pyarrow@23.0.1` ℹ Read more on: This package \| This alert \| What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore pypi/pyarrow@23.0.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		License policy violation: pypi `pyarrow` License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) License: Apache-2.0 WITH LLVM-exception - The applicable license policy does not permit this license (5) (pyarrow-23.0.1.dist-info/licenses/LICENSE.txt) From: requirements.txt → `pypi/pyarrow@23.0.1` ℹ Read more on: This package \| This alert \| What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore pypi/pyarrow@23.0.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

JGSweets · 2026-07-06T21:28:11Z

@shania-m this is ready for review. Looks like we needed a lot of mypy updates and some almostequal updtes for the new py versions

JGSweets · 2026-07-06T21:28:34Z

        # popping vocab and comparing as set below since order is random
        serialized_vocab = serialized_dict["data"].pop("vocab")

-        serialized = json.dumps(serialized_dict)


tests are the same, but now using almostequal for the assert on floats

JGSweets · 2026-07-08T15:29:35Z

@shania-m this is ready for review!

refactor: add py3.12 and py3.13 to tests

8e60bff

JGSweets requested a review from a team as a code owner July 6, 2026 15:45

fix: commit setting

9cab92c

fix: mypy issues

23b158f

JGSweets commented Jul 6, 2026

View reviewed changes

JGSweets added 8 commits July 6, 2026 11:42

fix: typing

ae1dc4b

refactor: update mypy

91a4a24

fix: issues with mypy

8caaba8

fix: cnn typing

7766077

fix: typing again

1cc50b5

fix: numpy typing

11454a3

fix: typing more

20320cd

fix: typing more

f1305c6

JGSweets commented Jul 6, 2026

View reviewed changes

JGSweets added 2 commits July 6, 2026 15:50

fix: req issue

ae11f3b

fix: test failure

004ce6c

JGSweets added 2 commits July 6, 2026 15:57

fix: bug in test

a9b83cb

fix: assertalmostequal

f5a238b

JGSweets commented Jul 6, 2026

View reviewed changes

JGSweets mentioned this pull request Jul 7, 2026

Codeowners file updated to add ospo team #1213

Open

Uh oh!

Conversation

JGSweets commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JGSweets commented Jul 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

socket-security Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JGSweets commented Jul 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JGSweets commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

JGSweets commented Jul 6, 2026 •

edited

Loading

socket-security Bot commented Jul 6, 2026 •

edited

Loading

socket-security Bot commented Jul 6, 2026 •

edited

Loading