Milestone 7 run build exec logs copy#4
Merged
Conversation
Grounded against container v1.0.0 --help (run/build/exec/copy/logs/machine run). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
- TaskState gains a neutral .cancelled (not a failure; grey, still retryable) - OperationKind gains build/run/export/systemStart/copy - ProgressParser promotes a task to determinate progress on a clean NN% line - TaskCenter.cancel() cancels the driver (terminates the child via stream teardown) - Activity pane + TaskTranscriptView: Stop button + linear progress Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
Both route through the TaskCenter when wired (visible, cancellable, raw transcript on failure); the no-center path is kept for previews/tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
- RunConfiguration/BuildConfiguration own a computed argv (single source of truth shared by the adapter and the domain terminal-request builder) - ContainerFileEntry + lenient ls -la parser for the copy file browser - ContainerBackend: runContainer (detached, returns id), buildImage (stream), copyTo/FromContainer, fetchLogs (snapshot/tail/boot), listContainerDirectory - CLICommand emits canonical 'copy' (not 'cp'); MockBackend records all inputs Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
…inal, triage) - CommandTokenizer splits quoted command strings into argv - validatedConfiguration() maps the draft to a RunConfiguration (field errors) - commandPreview is the live 'Run Inspector'; runDetached registers a .run task + reloads; runInTerminal emits a .runInteractive TerminalRequest (or copies) - failed detached runs keep triage state (resolve image / inspect logs / retry) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
- QuickRunSheet: image/name + dynamic port/env/volume rows + command override, live command preview (Run Inspector), interactive→terminal / detached→task - RunFailureTriageView: resolve image / inspect logs (transcript) / retry in terminal - ImageListView gains a Run toolbar button + 'Run Image…' context action - composition: RunModel wired through the view chain; taskCenter now injected into SystemStatusModel + ContainerLifecycleModel for export/system-start tasks Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
…rt, plain retry) - BuildModel: draft + presets (standard/no-cache/plain), validation, streaming .build task (reloads images on success), retryPlain() forces --progress plain - BuildSheet: drag/drop or choose a context folder, tag/Dockerfile/build-arg rows, live TaskTranscriptView (raw output never hidden), Export Transcript, plain retry - ImageListView gains a Build toolbar button; buildModel wired through composition Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
…llback - ContainerLifecycleModel: execShell(id:command:) (custom command), openMachineShell, openInExternalTerminal (detach fallback seam) - ExecSheet: command field + live preview, Run (embedded terminal) or Open in Terminal.app - Container row menu: Open Shell + Exec… for a single running container - embedded terminal header gains an 'Open in Terminal.app' detach button - AppEnvironment writes an executable .command script + opens it via NSWorkspace Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
…h/save) - LogsModel: follow stream or bounded snapshot, case-insensitive search filter, saveable transcript, cancellable - LogsPaneView: follow/tail/boot controls, search, reload, save, auto-scroll - LogWindow: a detachable Window scene hosting the pane - container row 'Logs…' action starts capture + opens the window; View ▸ Open Log Window (⇧⌘L) command; logsModel wired through composition Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
…lidation - CopyModel: direction, host URL + container id:path with early validation (absolute path required, with an example), .copy Activity task, best-effort container directory browse (mapped to a UI-facing ContainerFileItem) - CopySheet: direction control, host drop-zone/Choose, container id:path with a Browse disclosure (navigate dirs, pick a file), drag-drop, inline validation - container row 'Copy Files…' action; copyModel wired through composition Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
… TaskCenter Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
…g tail, temp cleanup) - LogsModel: a replaced (cancelled) follow task no longer clears isStreaming on its successor (stale-task race); regression test added - Run triage 'Resolve Image' now prefills the Pull sheet with the failed image (ImageSheet.pull carries a reference; PullImageSheet gains initialReference) - fetchLogs drops the trailing newline so a snapshot has no spurious blank line - Open-in-Terminal.app sweeps its throwaway .command script 10s after launch No Critical/High findings; argv, cancellation, isolation, and arch boundary all verified correct by the review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRY8sjZCmM87FEsjo8A4he
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.