fix(web): deploy, deploy revoke and deploy list refusals reach the caller - #342
Merged
Merged
Conversation
…ller
Seven guards across the three deploy-family classes. All sit inside an
execute() whose catch routes to displayErrorAndExit, so each becomes a coded
throw and the existing catch serves the page.
DeployCommand authentication failed AUTH_FAILED
bad --platform value INVALID_FORMAT
DeployRevokeCommand uninitialised project PROJECT_NOT_INITIALIZED
authentication failed AUTH_FAILED
no token with that prefix DEPLOY_TOKEN_NOT_FOUND
DeployListCommand uninitialised project PROJECT_NOT_INITIALIZED
authentication failed AUTH_FAILED
TWO ARE DELIBERATELY LEFT, both for the same reason: the message is already on
screen before the exit, so converting them would print it twice — once by the
existing call and once by the error screen.
mintOrExit `spinner.fail(...)` has already rendered the failure
ambiguous prefix a multi-line `console.error` concatenation
Each needs its existing output folded into the throw, which is an edit with a
copy decision in it rather than a mechanical one. Same call as the two
role-grant refusals left in inviteCommand.
Suite: 1851 pass, 0 fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven guards across the three deploy-family classes. All sit inside an
execute()whose catch routes todisplayErrorAndExit, so each becomes a coded throw and the existing catch serves the page.DeployCommandAUTH_FAILED--platformvalueINVALID_FORMATDeployRevokeCommandPROJECT_NOT_INITIALIZEDAUTH_FAILEDDEPLOY_TOKEN_NOT_FOUNDDeployListCommandPROJECT_NOT_INITIALIZEDAUTH_FAILEDTwo deliberately left
Both for the same reason: the message is already on screen before the exit, so converting would print it twice — once by the existing call, once by the error screen.
mintOrExit—spinner.fail(...)has already rendered the failureconsole.errorconcatenationEach needs its existing output folded into the throw, which is an edit with a copy decision in it rather than a mechanical one. Same call as the two role-grant refusals left in
inviteCommand.Suite: 1851 pass, 0 fail.