Revamp MLP UI Sidebar Menu#15
Conversation
| } | ||
| ]; | ||
|
|
||
| const docLinks = [ |
There was a problem hiding this comment.
This has to be configurable and I don't think we should include link to gojek internal documentations
There was a problem hiding this comment.
+1 on making it configurable.
There was a problem hiding this comment.
🤦 just realised this. Should we make it configurable from db?
| {({ projectId }) => projectId && <NavDrawer />} | ||
| </CurrentProjectContext.Consumer> | ||
| <Component {...props} /> | ||
| <div style={{ paddingTop: "49px" }}> |
| } | ||
| aria-label="Machine Learning Platform" | ||
| /> | ||
| <EuiText style={{ padding: "10px" }}> |
| showCloseButton={false} | ||
| isDocked={navIsDocked} | ||
| showButtonIfDocked={true} | ||
| style={{ top: "49px", height: "calc(100% - 49px)", width: "262px" }} |
| </EuiCollapsibleNavGroup> | ||
| </EuiFlexItem> | ||
|
|
||
| <EuiHorizontalRule margin="none" /> |
|
I'm not sure if it's a good idea to have component-level user manuals be shown at once, independently from what product is currently in-use. |
|
Since we already touching sidebar, I think it makes sense to make product menu items (e.g. 'Merlin', 'Feast') to be expandable and have quick-access links to specific resources of a relevant component under them. Somethin like: v Merlin |
pradithya
left a comment
There was a problem hiding this comment.
LGTM, Can you explicitly mention in the MR description how the new NavDrawer behave especially in term of how respective product can add their docs link.
I think we can implement your suggestion in the next milestone |

Change the looks and experience of sidebar menu. In this PR only UI files that modified. Below are attached screenshots
When merlin integrate with new sidebar menu, merlin app is highlighted because currently active app is merlin

Sidebar menu will be moved to Header, hence to use this new sidebar menu, user just need to specify the header
where docLinks is list of documentation that relevant to be shown which has format like: