Skip to content

Update merlin links in sidebar#66

Merged
ariefrahmansyah merged 4 commits into
mainfrom
menubar
Oct 26, 2022
Merged

Update merlin links in sidebar#66
ariefrahmansyah merged 4 commits into
mainfrom
menubar

Conversation

@karzuo
Copy link
Copy Markdown
Contributor

@karzuo karzuo commented Oct 25, 2022

-Add transformer simulator to sidebar for merlin

@karzuo karzuo self-assigned this Oct 25, 2022
Comment thread db-migrations/11_update_merlin_app_config.down.sql
@tiopramayudi
Copy link
Copy Markdown
Collaborator

LGTM

@ariefrahmansyah ariefrahmansyah merged commit 5695f03 into main Oct 26, 2022
@ariefrahmansyah ariefrahmansyah deleted the menubar branch October 26, 2022 04:46
ariefrahmansyah added a commit to caraml-dev/merlin that referenced this pull request Oct 26, 2022
<!--  Thanks for sending a pull request!  Here are some tips for you:

1. Run unit tests and ensure that they are passing
2. If your change introduces any API changes, make sure to update the
e2e tests
3. Make sure documentation is updated for your PR!

-->

**What this PR does / why we need it**:
<!-- Explain here the context and why you're making the change. What is
the problem you're trying to solve. --->

This PR in MLP (caraml-dev/mlp#66) adds transformer
simulator link on sidebar. Hence we need to update the corresponding
link in Merlin side.

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

Fixes #

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required. Enter your extended release note in
the block below.
If the PR requires additional action from users switching to the new
release, include the string "action required".

For more information about release notes, see kubernetes' guide here:
http://git.k8s.io/community/contributors/guide/release-notes.md
-->

```release-note
Add Transformer Simulator link on sidebar.
```

**Checklist**

- [ ] Added unit test, integration, and/or e2e tests
- [x] Tested locally
- [ ] Updated documentation
- [ ] Update Swagger spec if the PR introduce API changes
- [ ] Regenerated Golang and Python client if the PR introduce API
changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants