Replace apiVersion for ingress in helm chart#67
Merged
Conversation
tiopramayudi
approved these changes
Oct 27, 2022
1 task
Collaborator
|
@gojek/roc-dev @pradithya what's our plan for preventing MLP chart drifting away from https://github.com/caraml-dev/helm-charts/tree/main/charts/mlp? |
Member
Author
|
Hmm, didn't realize that. Shall we remove this chart in that case? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merlin uses mlp chart to perform end to end test. However, the chart uses an already removed version of Ingress API and causing issue when running on Kubernetes 1.22 (https://github.com/gojek/merlin/actions/runs/3328466066/jobs/5504628894).
This PR replace
extensions/v1beta1/Ingresswithnetworking.k8s.io/v1/Ingressin the helm chart.