Skip to content

Conversation

@tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Apr 28, 2025

This brings in this fix: IBMa/equal-access#2248

Previously versioned wasn't actually locking the ruleset and was just grabbing the latest. This should ensure the ruleset in use doesn't change until we update accessibility-checker

Changelog

Changed

Testing / Reviewing

  • Double check the a11y status check logs to make sure nothing looks wrong

@tay1orjones tay1orjones requested a review from a team as a code owner April 28, 2025 18:12
@tay1orjones tay1orjones requested review from a team, alisonjoseph and heloiselui April 28, 2025 18:12
@tay1orjones tay1orjones self-assigned this Apr 28, 2025
@github-project-automation github-project-automation bot moved this to 🚦 In Review in Design System Apr 28, 2025
@netlify
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a1d08e6
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6876e0fc54cc7600082cdf02
😎 Deploy Preview https://deploy-preview-19251--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a1d08e6
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6876e0fc43485d0008e87925
😎 Deploy Preview https://deploy-preview-19251--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tay1orjones
Copy link
Member Author

tay1orjones commented May 20, 2025

The unit/jest tests that call toHaveNoACViolations are failing because accessibility-checker removed axios in favor of using fetch directly. Unfortunately jsdom does not include fetch, jsdom/jsdom#1724

Options, in order of my preference:

@tay1orjones tay1orjones mentioned this pull request Jun 4, 2025
6 tasks
@tay1orjones tay1orjones changed the title chore(project): update accessibility-checker to 4.0.4 chore(project): update accessibility-checker to ~4.0.4~ Jun 4, 2025
@tay1orjones tay1orjones changed the title chore(project): update accessibility-checker to ~4.0.4~ chore(project): update accessibility-checker to 4.0.6 Jun 4, 2025
@tay1orjones tay1orjones marked this pull request as draft June 4, 2025 18:50
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (644b34f) to head (a1d08e6).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19251   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files         476      476           
  Lines       29753    29753           
  Branches     5393     5344   -49     
=======================================
  Hits        27098    27098           
  Misses       2502     2502           
  Partials      153      153           
Flag Coverage Δ
main-packages 84.87% <ø> (ø)
web-components 97.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tay1orjones tay1orjones marked this pull request as ready for review July 11, 2025 19:31
Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a11y checks LGTM

Copy link
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tay1orjones tay1orjones added this pull request to the merge queue Jul 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2025
@ariellalgilmore ariellalgilmore added this pull request to the merge queue Jul 16, 2025
Merged via the queue into carbon-design-system:main with commit 283aca3 Jul 16, 2025
41 of 42 checks passed
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

When using versioned with 4.x, it is pulling the latest 3.x ruleset

5 participants