-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore(project): update accessibility-checker to 4.0.6 #19251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(project): update accessibility-checker to 4.0.6 #19251
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The unit/jest tests that call Options, in order of my preference:
|
…date-accessibility-checker-4-0-4
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19251 +/- ##
=======================================
Coverage 91.07% 91.07%
=======================================
Files 476 476
Lines 29753 29753
Branches 5393 5344 -49
=======================================
Hits 27098 27098
Misses 2502 2502
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2nikhiltom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a11y checks LGTM
heloiselui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
283aca3
This brings in this fix: IBMa/equal-access#2248
Previously
versionedwasn't actually locking the ruleset and was just grabbing the latest. This should ensure the ruleset in use doesn't change until we updateaccessibility-checkerChangelog
Changed
4.0.4, waiting on 4.0.6 slated for end of Junefetch is not definedIBMa/equal-access#2283Testing / Reviewing