Skip to content

Conversation

@emyarod
Copy link
Member

@emyarod emyarod commented Mar 7, 2019

Closes #2009

This PR removes margins from tooltip labels which is breaking inline usage of the tooltip

@netlify
Copy link

netlify bot commented Mar 7, 2019

Deploy preview for the-carbon-components ready!

Built with commit 809ad3c

https://deploy-preview-2010--the-carbon-components.netlify.com

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍🏽

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, assuming the intent of margin-bottom is for the space between tooltip trigger and tooltip body. Thanks @emyarod for your quick fix!

@asudoh asudoh merged commit cbcc105 into carbon-design-system:master Mar 7, 2019
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.83.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emyarod emyarod deleted the 2009-remove-margin-from-tooltip-labels branch March 8, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants