Skip to content

Conversation

@clairek20
Copy link
Contributor

@clairek20 clairek20 commented Oct 5, 2021

Pull request - feature(ICA): Add information icon to label, and edit icon with tooltip to value

Proposed changes

feature(ICA): Add information icon to label, and edit icon with tooltip to value

@clairek20 clairek20 requested a review from a team as a code owner October 5, 2021 12:41
@clairek20 clairek20 requested review from j1mie and removed request for a team October 5, 2021 12:41
@netlify
Copy link

netlify bot commented Oct 5, 2021

✔️ Deploy Preview for ibm-security ready!

🔨 Explore the source changes: 12c1016

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/6160564f7a673b000770e0fb

😎 Browse the preview: https://deploy-preview-1110--ibm-security.netlify.app

@clairek20 clairek20 requested a review from SimonFinney October 6, 2021 08:32
@clairek20
Copy link
Contributor Author

Hi @SimonFinney
I assigned this to you as i'm not sure who else can review. The CI build seems to be failing for all new PR's but i'm not sure how to resolve(i've updated all the tests).
Thanks in advance, Claire.

@SimonFinney SimonFinney removed the request for review from j1mie October 6, 2021 13:32
@clairek20 clairek20 requested a review from dbrugger October 7, 2021 09:29
@clairek20 clairek20 force-pushed the make_label_and_value_prop_node branch from be08cb1 to 7a134d4 Compare October 7, 2021 15:20
@clairek20 clairek20 force-pushed the make_label_and_value_prop_node branch from d79e507 to 4c4f943 Compare October 7, 2021 17:55
@clairek20 clairek20 changed the title feature(ICA): Make label and value node prop types feature(ICA): feature(ICA): Add information icon to label, and edit icon with tooltip to value Oct 7, 2021
@clairek20 clairek20 force-pushed the make_label_and_value_prop_node branch from 6ff0316 to 2a9b6ee Compare October 7, 2021 18:00
@clairek20 clairek20 force-pushed the make_label_and_value_prop_node branch from 64740d4 to 3d3427e Compare October 8, 2021 09:24
@dbrugger dbrugger changed the title feature(ICA): feature(ICA): Add information icon to label, and edit icon with tooltip to value feature(ICA): feature(ICA): Add optional information and iconButton prop Oct 8, 2021
@dbrugger dbrugger changed the title feature(ICA): feature(ICA): Add optional information and iconButton prop feature(ICA): Add optional information and iconButton prop Oct 8, 2021
@clairek20 clairek20 force-pushed the make_label_and_value_prop_node branch from f3f73e4 to 8345dc1 Compare October 8, 2021 13:59
@dbrugger dbrugger merged commit a5aa52b into dev Oct 8, 2021
@dbrugger dbrugger deleted the make_label_and_value_prop_node branch October 8, 2021 14:43
@dbrugger dbrugger changed the title feature(ICA): Add optional information and iconButton prop feat(ICA): Add optional information and iconButton prop Oct 8, 2021
@clairek20 clairek20 restored the make_label_and_value_prop_node branch October 12, 2021 08:09
clairek20 added a commit that referenced this pull request Oct 12, 2021
kodiakhq bot pushed a commit that referenced this pull request Oct 12, 2021
clairek20 added a commit that referenced this pull request Oct 12, 2021
SimonFinney pushed a commit that referenced this pull request Oct 12, 2021
# [1.45.0-prerelease.12](v1.45.0-prerelease.11...v1.45.0-prerelease.12) (2021-10-12)

### Reverts

* Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115) ([86ad1c7](86ad1c7)), closes [#1110](#1110) [#1115](#1115)
@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 1.45.0-prerelease.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot added a commit that referenced this pull request Oct 12, 2021
… prop (#1110)" (#1115)" (#1116)

This reverts commit 86ad1c7.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@SimonFinney SimonFinney deleted the make_label_and_value_prop_node branch October 12, 2021 08:54
SimonFinney pushed a commit that referenced this pull request Oct 12, 2021
# [1.45.0-prerelease.13](v1.45.0-prerelease.12...v1.45.0-prerelease.13) (2021-10-12)

### Reverts

* Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116)
SimonFinney pushed a commit that referenced this pull request Oct 13, 2021
# [1.46.0](v1.45.0...v1.46.0) (2021-10-13)

### Bug Fixes

* **decorator:** fix icon `fill` styles ([#1103](#1103)) ([dea56f9](dea56f9))
* **nav-item-link:** remove fixed height to prevent issues with multi-line text ([#1085](#1085)) ([0e0f542](0e0f542))
* **navitem:** Remove blue lines in safari ([#1106](#1106)) ([5cae584](5cae584))
* **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a))
* **tearsheet-small:** update maximum size styles ([#968](#968)) ([d8bc055](d8bc055))
* **toolbar:** vertical icon alignment for multi-line labels ([#1089](#1089)) ([0183591](0183591))

### Features

* **decorator:** add onContextMenu to decorator ([#1102](#1102)) ([46f29da](46f29da))
* **deps:** add remaining Carbon dependencies ([#1101](#1101)) ([c5bd47b](c5bd47b))
* **focus-trap-react:** upgrade package and fix dependency ([#1111](#1111)) ([ffe9c8a](ffe9c8a))

### Reverts

* Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116)
* Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115) ([86ad1c7](86ad1c7)), closes [#1110](#1110) [#1115](#1115)
@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 1.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants