Skip to content

Conversation

@SimonFinney
Copy link
Contributor

Affected issue

Resolves #1109

Proposed changes

  • Upgrade focus-trap-react dependency
  • Change initialFocus defaultProp to undefined by removing it

@SimonFinney SimonFinney requested a review from a team as a code owner October 6, 2021 15:54
@netlify
Copy link

netlify bot commented Oct 6, 2021

✔️ Deploy Preview for ibm-security ready!

🔨 Explore the source changes: 17f1a6c

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/615dc6abac4f410007952bb3

😎 Browse the preview: https://deploy-preview-1111--ibm-security.netlify.app/

@SimonFinney SimonFinney removed the request for review from lily-peng October 6, 2021 16:09
@kodiakhq kodiakhq bot merged commit ffe9c8a into dev Oct 7, 2021
@kodiakhq kodiakhq bot deleted the upgrade-dependencies branch October 7, 2021 08:36
SimonFinney pushed a commit that referenced this pull request Oct 7, 2021
# [1.45.0-prerelease.9](v1.45.0-prerelease.8...v1.45.0-prerelease.9) (2021-10-07)

### Features

* **focus-trap-react:** upgrade package and fix dependency ([#1111](#1111)) ([ffe9c8a](ffe9c8a))
@SimonFinney
Copy link
Contributor Author

🎉 This PR is included in version 1.45.0-prerelease.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

SimonFinney pushed a commit that referenced this pull request Oct 13, 2021
# [1.46.0](v1.45.0...v1.46.0) (2021-10-13)

### Bug Fixes

* **decorator:** fix icon `fill` styles ([#1103](#1103)) ([dea56f9](dea56f9))
* **nav-item-link:** remove fixed height to prevent issues with multi-line text ([#1085](#1085)) ([0e0f542](0e0f542))
* **navitem:** Remove blue lines in safari ([#1106](#1106)) ([5cae584](5cae584))
* **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a))
* **tearsheet-small:** update maximum size styles ([#968](#968)) ([d8bc055](d8bc055))
* **toolbar:** vertical icon alignment for multi-line labels ([#1089](#1089)) ([0183591](0183591))

### Features

* **decorator:** add onContextMenu to decorator ([#1102](#1102)) ([46f29da](46f29da))
* **deps:** add remaining Carbon dependencies ([#1101](#1101)) ([c5bd47b](c5bd47b))
* **focus-trap-react:** upgrade package and fix dependency ([#1111](#1111)) ([ffe9c8a](ffe9c8a))

### Reverts

* Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116)
* Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115) ([86ad1c7](86ad1c7)), closes [#1110](#1110) [#1115](#1115)
@SimonFinney
Copy link
Contributor Author

🎉 This PR is included in version 1.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get 'initialFocus' error when using TearSheetSmall with focus-trap-react 8.8.1 installed

2 participants