CBAPI - 3877 - Change the attrdict builtin#314
Merged
Conversation
avanbrunt-cb
requested changes
Jun 14, 2022
Contributor
avanbrunt-cb
left a comment
There was a problem hiding this comment.
Please don't use attrdict3 as that is out of our control and the behavior we need can be easily replicated. See carbonblack/carbon-black-cloud-sdk-python#5
Contributor
Author
|
@avanbrunt-cb Should I merge this and release it as a new version? |
kebringer-cb
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the ticket or issue number?
CBAPI-3877 | #298
Pull Request Description
I've only changed the setup packages
attrdicttoattrdict3it seems complex to change the whole auth file and since that there are no tests I've decided to go to the easies solution.Does this introduce a breaking change?