Put keyed reminders in the release they ship in - #9
Merged
Conversation
0.13.2 has a section and a version but was never published, so the keyed reminder entry sat under Unreleased above a release that had not happened. Anyone reading the changelog would have taken 0.13.2 for shipped and the feature for waiting on a later one. Folds the entry into 0.13.2 and dates it for the day it goes out.
Greptile SummaryThe PR moves the keyed-reminders changelog entry into the previously unreleased 0.13.2 section and updates that release date to 2026-08-17.
Confidence Score: 5/5The PR appears safe to merge. The documentation-only change consistently merges the pending changelog entry into the intended 0.13.2 release without altering runtime behavior. Important Files Changed
Reviews (1): Last reviewed commit: "Put keyed reminders in the release they ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the
Unreleasedchangelog entry into0.13.2and dates it for the day it goes out.Why
0.13.2has a changelog section andpackage.jsonalready says0.13.2, but it was never published — npm is still on0.13.1. Keyed reminders then landed and went underUnreleased, above a release that had not happened.Read from the outside that says 0.13.2 shipped and keyed reminders are waiting for something later, when in fact they go out together.
No version bump:
package.jsonis already0.13.2andpack:checkproducessolid-objects-0.13.2.tgz.Manual QA on merged main
I drove keyed reminders through a real actor with the scheduler and worker running, rather than asserting on intents:
Upgrading a database that already holds reminders
This is the part I most wanted to see for real, since the release adds a column and CI mostly exercises fresh installs. I took a database back to what a pre-keyed release left behind — dropping
message_operationand the record of migration 7 — with an alarm already armed in it, then reopened it:The alarm written before the column existed still fires after the upgrade, which is the
message_operation ?? operationfallback doing its job on a real row rather than in a unit test, and a keyed alarm then joins it in the same table.248 tests, 0 failures. Typecheck, format, parameter-style, documentation and
pack:checkall clean.One flake, not from this change
test/lifecycle.test.ts > renews an idle cached activation before its lease expiresfailed twice while I was running QA in parallel, expectingactivation: 1and gettingactivation: 2. It is a lease-renewal timing assertion, and that file runs withreminderSchedulerCount: 0, so reminders are not involved. On a quiet machine it passed 6 runs out of 6. Worth knowing it is load-sensitive; not worth blocking on.Note
The matching Ruby release is cardmagic/solid_objects#43.