Fix Ask/Act toggle missing default selection on new session#4261
Merged
jurgenwerk merged 2 commits intoMar 30, 2026
Merged
Conversation
Normalize @selected in LLMModeToggle so the toggle always defaults to "Ask" when the value is not explicitly "act". This prevents a blank toggle during transient room-resource states introduced by the memory leak cleanup teardown path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Preview deployments |
Contributor
backspace
approved these changes
Mar 27, 2026
Contributor
backspace
left a comment
backspace
left a comment
There was a problem hiding this comment.
This fixes the problem, but is there any possibility of finding out what caused it and adding a test for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening starting a new session in the AI assistant, the toggle is sometimes untoggled:
Summary
@selectedinLLMModeToggleso the toggle always defaults to "Ask" when the value is not explicitly"act"f3fb792)Test plan
🤖 Generated with Claude Code