Skip to content

Fix Ask/Act toggle missing default selection on new session #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurgenwerk merged 2 commits into from
Mar 30, 2026
Merged

Fix Ask/Act toggle missing default selection on new session #4261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b73521
Fix Ask/Act toggle missing default selection on new session
jurgenwerk Mar 27, 2026
b9ff840
Add a default state test for ask/act toggle
jurgenwerk Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/host/app/components/ai-assistant/llm-mode-toggle.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,17 @@ interface Signature {
}

export default class LLMModeToggle extends Component<Signature> {
private get selected(): LLMMode {
return this.args.selected === 'act' ? 'act' : 'ask';
}

<template>
<div class='llm-mode-toggle' ...attributes>
<Tooltip @placement='top'>
<:trigger>
<button
type='button'
class='llm-mode-option {{if (eq @selected "ask") "selected"}}'
class='llm-mode-option {{if (eq this.selected "ask") "selected"}}'
data-test-llm-mode-option='ask'
disabled={{@disabled}}
{{on 'click' (fn this.handleOptionClick 'ask')}}
Expand All @@ -45,7 +49,7 @@ export default class LLMModeToggle extends Component<Signature> {
<:trigger>
<button
type='button'
class='llm-mode-option {{if (eq @selected "act") "selected"}}'
class='llm-mode-option {{if (eq this.selected "act") "selected"}}'
data-test-llm-mode-option='act'
disabled={{@disabled}}
{{on 'click' (fn this.handleOptionClick 'act')}}
Expand Down Expand Up @@ -102,7 +106,7 @@ export default class LLMModeToggle extends Component<Signature> {

@action
private handleOptionClick(mode: LLMMode) {
if (mode !== this.args.selected) {
if (mode !== this.selected) {
this.args.onChange(mode);
}
}
Expand Down
23 changes: 23 additions & 0 deletions packages/host/tests/acceptance/ai-assistant-test.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3008,6 +3008,29 @@ module('Acceptance | AI Assistant tests', function (hooks) {
.exists();
});

test('ask/act toggle defaults to ask on new session', async function (assert) {
await visitOperatorMode({
stacks: [
[
{
id: `${testRealmURL}index`,
format: 'isolated',
},
],
],
});

await click('[data-test-open-ai-assistant]');
await waitFor('[data-room-settled]');

assert
.dom('[data-test-llm-mode-option="ask"]')
.hasClass('selected', 'Ask is selected by default on new session');
assert
.dom('[data-test-llm-mode-option="act"]')
.doesNotHaveClass('selected', 'Act is not selected by default');
});

test('new session inherits llm mode from current room', async function (assert) {
await visitOperatorMode({
stacks: [
Expand Down
Loading