Ruff hotfix - #1217
Merged
Merged
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 91 91
Lines 5411 5411
Branches 692 692
=======================================
Hits 4939 4939
Misses 338 338
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
marked this pull request as ready for review
August 15, 2026 01:26
henrydingliu
requested review from
genedan,
jbogaardt and
kennethshsu
as code owners
August 15, 2026 01:26
genedan
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
fixing ruff violations somehow left by #1205
Related GitHub Issue(s)
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Cosmetic formatting only; no logic or API changes beyond style.
Overview
Follow-up to #1205: Ruff-only cleanup in
chainladder/utils/utility_functions.pywith no intended behavior change.Updates include PEP 484-style spacing in
model_diagnosticsannotations (|unions), comma spacing inhasattrcalls, keyword-argument formatting onalign_pattern(sample_weight=...), and whitespace inside f-strings built byPTF_formula(index/subtraction and division aroundgraingamma/iotaknots).Reviewed by Cursor Bugbot for commit beec479. Bugbot is set up for automated code reviews on this repo. Configure here.