Skip to content

ruff fix - #1273

Merged
henrydingliu merged 1 commit into
casact:chapter_11_parkingfrom
henrydingliu:chapter_11
Sep 2, 2026
Merged

ruff fix#1273
henrydingliu merged 1 commit into
casact:chapter_11_parkingfrom
henrydingliu:chapter_11

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

Checklist

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)

Note

Low Risk
Documentation-only notebook edits that add lint suppressions; no runtime or library behavior changes.

Overview
Updates ruff lint suppressions in the Friedland Chapter 11 notebook so reconciliation assert cells that use visually aligned np.array literals pass the linter.

In the Exhibit V assertion cell, the existing # ruff: noqa: E241 line is broadened to # ruff: noqa: E231, E241, E242. The Exhibit VI assertion cell gets the same comment added at the top. No assertion values or exhibit logic change—only per-cell noqa directives.

Reviewed by Cursor Bugbot for commit bf15c16. Bugbot is set up for automated code reviews on this repo. Configure here.

@henrydingliu
henrydingliu merged commit 40dbd46 into casact:chapter_11_parking Sep 2, 2026
9 of 11 checks passed
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 15.1% of exported symbols fully typed (209 / 1380)

Known Ambiguous Unknown Total
Project (head) 209 112 1059 1380

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 325
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.75%. Comparing base (8efe214) to head (bf15c16).
⚠️ Report is 2 commits behind head on chapter_11_parking.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           chapter_11_parking    #1273   +/-   ##
===================================================
  Coverage               91.75%   91.75%           
===================================================
  Files                      93       93           
  Lines                    5447     5447           
  Branches                  702      702           
===================================================
  Hits                     4998     4998           
+ Misses                    330      326    -4     
- Partials                  119      123    +4     
Flag Coverage Δ
unittests 91.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant